starred/shiori

Fork 0

mirror of https://github.com/go-shiori/shiori.git synced 2026-04-25 14:35:52 +03:00

[GH-ISSUE #16] Would be nice to have a tag-cloud #9

New issue

Closed

opened 2026-02-25 23:33:14 +03:00 by kerem · 5 comments

kerem commented

2026-02-25 23:33:14 +03:00

Owner

Originally created by @skx on GitHub (Mar 2, 2018).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/16

This is a beautiful project! I've imported 500+ bookmarks and it can be a little hard to find what I want, when I'm not 100% sure.

I think it would be useful to change the "Reload" icon at the top-right with a link to a tag-cloud view. A user who wants to reload could just use "F5" - unless I misunderstand what that link does.

Seeing all the tags in one place is likely to be a useful thing, and help show more data. (Because the thumbnail view of the main index means it takes up a lot of space.)

Originally created by @skx on GitHub (Mar 2, 2018). Original GitHub issue: https://github.com/go-shiori/shiori/issues/16 This is a beautiful project! I've imported 500+ bookmarks and it can be a little hard to find what I want, when I'm not 100% sure. I think it would be useful to change the "Reload" icon at the top-right with a link to a tag-cloud view. A user who wants to reload could just use "F5" - unless I misunderstand what that link does. Seeing all the tags in one place is likely to be a useful thing, and help show more data. (Because the thumbnail view of the main index means it takes up a lot of space.)

kerem

2026-02-25 23:33:14 +03:00

closed this issue
added the
type:enhancement
label

kerem commented

2026-02-25 23:33:15 +03:00

Author

Owner

@peteretelej commented on GitHub (Mar 2, 2018):

A user who wants to reload could just use "F5" - unless I misunderstand what that link does

the reload button doesn't perform a page reload. It updates the bookmark results via ajax

@peteretelej commented on GitHub (Mar 2, 2018): > A user who wants to reload could just use "F5" - unless I misunderstand what that link does the reload button doesn't perform a page reload. It updates the bookmark results via ajax

kerem commented

2026-02-25 23:33:15 +03:00

Author

Owner

@skx commented on GitHub (Mar 2, 2018):

Ahh I misunderstood its purpose then! But regardless it would be nice to see a tag list/cloud page.

Looking at the code I think this will be pretty simple. I will submit a pull-request later in the day.

Edit: This turned out to be harder than I thought. I updated sqlite.go + database.go to add a new function:

      // FetchTags returns all the unique tags, and their use-count
      FetchTags() (map[string]int, error)

Then I updated the server to use that:

      router.GET("/tags", serveTagsPage)

However that's probably not the right way to go. I suspect instead I should be using an AJAX call beneath /api/tags and that is beyond me because fileb0x fails to regenerate my assets ("Token too long").

I'll leave this open as a wishlist, and hope it is accepted in the future.

@skx commented on GitHub (Mar 2, 2018): Ahh I misunderstood its purpose then! But regardless it would be nice to see a tag list/cloud page. Looking at the code I think this will be pretty simple. I will submit a pull-request later in the day. __Edit__: This turned out to be harder than I thought. I updated sqlite.go + database.go to add a new function: // FetchTags returns all the unique tags, and their use-count FetchTags() (map[string]int, error) Then I updated the server to use that: router.GET("/tags", serveTagsPage) However that's probably not the right way to go. I suspect instead I should be using an AJAX call beneath /api/tags and that is beyond me because fileb0x fails to regenerate my assets ("Token too long"). I'll leave this open as a wishlist, and hope it is accepted in the future. :)

kerem commented

2026-02-25 23:33:15 +03:00

Author

Owner

@skx commented on GitHub (Mar 6, 2018):

Looks like this has been implemented in :

https://github.com/RadhiFadlillah/shiori/pull/49

I'll close.

@skx commented on GitHub (Mar 6, 2018): Looks like this has been implemented in : * https://github.com/RadhiFadlillah/shiori/pull/49 I'll close.

kerem commented

2026-02-25 23:33:15 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Mar 10, 2018):

@skx I've merged it in eee3dc7. Could you check it out ?

@RadhiFadlillah commented on GitHub (Mar 10, 2018): @skx I've merged it in [eee3dc7](https://github.com/RadhiFadlillah/shiori/commit/eee3dc75c20a775e5b8fbb740490765518111377). Could you check it out ?

kerem commented

2026-02-25 23:33:15 +03:00

Author

Owner

@skx commented on GitHub (Mar 10, 2018):

Looks great, I'm happy to close this.

I'm sure I'm not alone in appreciating how responsive you've been to issues and pull-requests. :)

@skx commented on GitHub (Mar 10, 2018): Looks great, I'm happy to close this. I'm sure I'm not alone in appreciating how responsive you've been to issues and pull-requests. :)