follow themes in the webui #871

New issue

Closed

opened 2026-02-25 23:35:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/924
Author: @Monirzadeh
Created: 6/1/2024
Status: ✅ Merged
Merged: 6/6/2024
Merged by: @fmartingr

Base: master ← Head: issue-215

📝 Commits (10+)

732e434 login page follow browser darkmode settings
08fff0a theme change based on selection in settings between follw system , light, dark
3f23d21 content page follow settings and fix syntax error
2fc4ca2 drop down menu color follow current theme
36afa0f version number follow theme in login page
b034a17 use footer instead of id for version
9a65f43 replace space with tab
141cd02 move theme settings to the top of the list and fix typo
33a9fce remove duplicate code and use a function instead
4dbc3b4 Merge branch 'master' into issue-215

📊 Changes

14 files changed (+116 additions, -80 deletions)

View changed files

📝 docs/swagger/docs.go (+3 -3)
📝 docs/swagger/swagger.json (+3 -3)
📝 docs/swagger/swagger.yaml (+2 -2)
📝 internal/http/routes/api/v1/auth_test.go (+2 -2)
📝 internal/model/account.go (+9 -9)
📝 internal/view/assets/css/style.css (+1 -1)
📝 internal/view/assets/js/page/base.js (+17 -1)
📝 internal/view/assets/js/page/setting.js (+9 -5)
📝 internal/view/assets/less/common.less (+7 -31)
📝 internal/view/assets/less/style.less (+1 -0)
➕ internal/view/assets/less/theme.less (+47 -0)
📝 internal/view/content.html (+6 -7)
📝 internal/view/index.html (+6 -6)
📝 internal/view/login.html (+3 -10)

📄 Description

This PR try to fix #251 and some other fix

fix warrning in login page
Login page allways follow system settings theme
have 3 option Follow system settings, Light , and dark theme
hide old NightMode from settings and replace that with drop down menu
fix bug that theme not apply if you select dark mode in browser
content page follow same settings
fix content page load-settings wrong syntax that block from load settings completely
drop down menu follow theme color
fix version number be always black in login page. now it follow the theme color

Closes #251
Closes #561

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/924 **Author:** [@Monirzadeh](https://github.com/Monirzadeh) **Created:** 6/1/2024 **Status:** ✅ Merged **Merged:** 6/6/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `issue-215` --- ### 📝 Commits (10+) - [`732e434`](https://github.com/go-shiori/shiori/commit/732e434d6b6c57a4e1608740bd06b1066f17faa3) login page follow browser darkmode settings - [`08fff0a`](https://github.com/go-shiori/shiori/commit/08fff0a8f32af9ea9f581a43336b62b27319e633) theme change based on selection in settings between follw system , light, dark - [`3f23d21`](https://github.com/go-shiori/shiori/commit/3f23d2121dfbfec33b7aae18a8cd9aff3740b427) content page follow settings and fix syntax error - [`2fc4ca2`](https://github.com/go-shiori/shiori/commit/2fc4ca26d342202409a487d046501ea9bf0f9bbd) drop down menu color follow current theme - [`36afa0f`](https://github.com/go-shiori/shiori/commit/36afa0f222bd0f47faeaa70e56e9ae42ab0c4405) version number follow theme in login page - [`b034a17`](https://github.com/go-shiori/shiori/commit/b034a176533f05fb13d330d7053c52f55661dfe3) use footer instead of id for version - [`9a65f43`](https://github.com/go-shiori/shiori/commit/9a65f43d3fcda970fecc3c1a1bebe46812a062be) replace space with tab - [`141cd02`](https://github.com/go-shiori/shiori/commit/141cd02013489c107a4d8f1a7e44a8163749715e) move theme settings to the top of the list and fix typo - [`33a9fce`](https://github.com/go-shiori/shiori/commit/33a9fceaa7e02c82515a3ea58e836d7187b64b19) remove duplicate code and use a function instead - [`4dbc3b4`](https://github.com/go-shiori/shiori/commit/4dbc3b4b8f1961996a6c728eabf0e72866cb1cfd) Merge branch 'master' into issue-215 ### 📊 Changes **14 files changed** (+116 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `docs/swagger/docs.go` (+3 -3) 📝 `docs/swagger/swagger.json` (+3 -3) 📝 `docs/swagger/swagger.yaml` (+2 -2) 📝 `internal/http/routes/api/v1/auth_test.go` (+2 -2) 📝 `internal/model/account.go` (+9 -9) 📝 `internal/view/assets/css/style.css` (+1 -1) 📝 `internal/view/assets/js/page/base.js` (+17 -1) 📝 `internal/view/assets/js/page/setting.js` (+9 -5) 📝 `internal/view/assets/less/common.less` (+7 -31) 📝 `internal/view/assets/less/style.less` (+1 -0) ➕ `internal/view/assets/less/theme.less` (+47 -0) 📝 `internal/view/content.html` (+6 -7) 📝 `internal/view/index.html` (+6 -6) 📝 `internal/view/login.html` (+3 -10) </details> ### 📄 Description This PR try to fix #251 and some other fix - [x] fix warrning in login page - [x] Login page allways follow system settings theme - [x] have 3 option Follow system settings, Light , and dark theme - [x] hide old NightMode from settings and replace that with drop down menu - [x] fix bug that theme not apply if you select dark mode in browser - [x] content page follow same settings - [x] fix content page load-settings wrong syntax that block from load settings completely - [x] drop down menu follow theme color - [x] fix version number be always black in login page. now it follow the theme color Closes #251 Closes #561 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>