[PR #921] [CLOSED] refactor(apiv1): refactor tags api to v1 #866

New issue

Closed

opened 2026-02-25 23:35:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/921
Author: @fmartingr
Created: 5/26/2024
Status: ❌ Closed

Base: master ← Head: feat/apiv1/tags

📝 Commits (10+)

27ee126 wip
c9fcb04 Merge branch 'master' into feat/apiv1/tags
490f24d refactor: Add DeleteTag method and Deleted field to tag model
4e90e50 fix: Add UpdateTag method to database implementations
d030ca8 refactor: Remove duplicate DeleteTag method declaration in database interface
aedc1c0 fix: Resolve tag domain method signature and error handling
217cdba refactor: Rename TagDomain to TagsDomain and add constructor function
8fa3b7f feat: Add CreateTags method to TagsDomain for bulk tag creation
ccc8293 feat: use tagsdomain
e7a9eb0 test: Add unit tests for tags domain logic

📊 Changes

20 files changed (+636 additions, -61 deletions)

View changed files

📝 Makefile (+5 -0)
📝 docs/swagger/docs.go (+5 -2)
📝 docs/swagger/swagger.json (+5 -2)
📝 docs/swagger/swagger.yaml (+4 -2)
📝 go.mod (+2 -0)
📝 go.sum (+5 -0)
📝 internal/cmd/root.go (+1 -0)
📝 internal/database/database.go (+7 -1)
📝 internal/database/database_test.go (+139 -3)
📝 internal/database/mysql.go (+60 -14)
📝 internal/database/pg.go (+60 -7)
📝 internal/database/sqlite.go (+60 -14)
📝 internal/dependencies/dependencies.go (+1 -0)
➕ internal/domains/tags.go (+87 -0)
➕ internal/domains/tags_test.go (+148 -0)
📝 internal/http/routes/api/v1/tags.go (+5 -4)
📝 internal/model/domains.go (+8 -1)
📝 internal/model/tag.go (+27 -5)
📝 internal/testutil/shiori.go (+1 -0)
📝 internal/view/assets/js/page/home.js (+6 -6)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/921 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 5/26/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat/apiv1/tags` --- ### 📝 Commits (10+) - [`27ee126`](https://github.com/go-shiori/shiori/commit/27ee126ddd57e88b139a616d6f29b5e265b73086) wip - [`c9fcb04`](https://github.com/go-shiori/shiori/commit/c9fcb04130ab5110c1717bb2e59b42603e39db7c) Merge branch 'master' into feat/apiv1/tags - [`490f24d`](https://github.com/go-shiori/shiori/commit/490f24d91f0e9887b5168f607b41364d38012439) refactor: Add DeleteTag method and Deleted field to tag model - [`4e90e50`](https://github.com/go-shiori/shiori/commit/4e90e50aa5b78f67aa123c8041511fb77feee067) fix: Add UpdateTag method to database implementations - [`d030ca8`](https://github.com/go-shiori/shiori/commit/d030ca8e5593a6739847b753f4f54e118d2b2da0) refactor: Remove duplicate DeleteTag method declaration in database interface - [`aedc1c0`](https://github.com/go-shiori/shiori/commit/aedc1c0e5908c87c8948ad015b638ede08606a47) fix: Resolve tag domain method signature and error handling - [`217cdba`](https://github.com/go-shiori/shiori/commit/217cdbad424f55b0768f577a8b6c1fb53c0c6c8b) refactor: Rename TagDomain to TagsDomain and add constructor function - [`8fa3b7f`](https://github.com/go-shiori/shiori/commit/8fa3b7f1539983819dcf6f9cc377deab9d4d36e9) feat: Add CreateTags method to TagsDomain for bulk tag creation - [`ccc8293`](https://github.com/go-shiori/shiori/commit/ccc82936d219405464f557ae1780be81b7d2433b) feat: use tagsdomain - [`e7a9eb0`](https://github.com/go-shiori/shiori/commit/e7a9eb0d4f767add1ccf7d4e1dfb4c1b12457605) test: Add unit tests for tags domain logic ### 📊 Changes **20 files changed** (+636 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+5 -0) 📝 `docs/swagger/docs.go` (+5 -2) 📝 `docs/swagger/swagger.json` (+5 -2) 📝 `docs/swagger/swagger.yaml` (+4 -2) 📝 `go.mod` (+2 -0) 📝 `go.sum` (+5 -0) 📝 `internal/cmd/root.go` (+1 -0) 📝 `internal/database/database.go` (+7 -1) 📝 `internal/database/database_test.go` (+139 -3) 📝 `internal/database/mysql.go` (+60 -14) 📝 `internal/database/pg.go` (+60 -7) 📝 `internal/database/sqlite.go` (+60 -14) 📝 `internal/dependencies/dependencies.go` (+1 -0) ➕ `internal/domains/tags.go` (+87 -0) ➕ `internal/domains/tags_test.go` (+148 -0) 📝 `internal/http/routes/api/v1/tags.go` (+5 -4) 📝 `internal/model/domains.go` (+8 -1) 📝 `internal/model/tag.go` (+27 -5) 📝 `internal/testutil/shiori.go` (+1 -0) 📝 `internal/view/assets/js/page/home.js` (+6 -6) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>