[PR #906] [MERGED] fix: not checking for nil-pointer errors on migrations #859

New issue

Closed

opened 2026-02-25 23:35:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/906
Author: @fmartingr
Created: 5/12/2024
Status: ✅ Merged
Merged: 5/12/2024
Merged by: @fmartingr

Base: master ← Head: fix/migrations-state

📝 Commits (3)

e65b18e check non-nil err
e0fa4cc apply to mysql and sqlite too
af01af3 Merge branch 'master' into fix/migrations-state

📊 Changes

3 files changed (+6 additions, -6 deletions)

View changed files

📝 internal/database/mysql.go (+2 -2)
📝 internal/database/pg.go (+2 -2)
📝 internal/database/sqlite.go (+2 -2)

📄 Description

Fix potential panic by checking err before doing comparisons over it.

Fixes #904

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/906 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 5/12/2024 **Status:** ✅ Merged **Merged:** 5/12/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix/migrations-state` --- ### 📝 Commits (3) - [`e65b18e`](https://github.com/go-shiori/shiori/commit/e65b18eddf5e06d44b4222973dba9460336acd0f) check non-nil err - [`e0fa4cc`](https://github.com/go-shiori/shiori/commit/e0fa4cc0e02270d46cc2c3bc9540a78538158e7c) apply to mysql and sqlite too - [`af01af3`](https://github.com/go-shiori/shiori/commit/af01af395112cd335d81472c701261dede1347a4) Merge branch 'master' into fix/migrations-state ### 📊 Changes **3 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `internal/database/mysql.go` (+2 -2) 📝 `internal/database/pg.go` (+2 -2) 📝 `internal/database/sqlite.go` (+2 -2) </details> ### 📄 Description Fix potential panic by checking `err` before doing comparisons over it. Fixes #904 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>