[PR #903] feat: deleted time added to the database #856

New issue

Open

opened 2026-02-25 23:35:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/903
Author: @Monirzadeh
Created: 5/8/2024
Status: 🔄 Open

Base: master ← Head: deleted_at

📝 Commits (9)

093076d add deleted table and record deleted_at inside that for sqlite
9f94610 add deleted table and record deleted_at inside that for postgres
bcc6ebf add deleted table and record deleted_at inside that for mariadb
9ff08a3 Merge branch 'master' into deleted_at
9a8a0b8 change migrate filename for sqlite
df57023 Merge branch 'deleted_at' of github.com:Monirzadeh/shiori into deleted_at
7b39432 fix golangci error
d79be9b restore wrong file commit
aaf0d16 Merge branch 'master' into deleted_at

📊 Changes

6 files changed (+51 additions, -0 deletions)

View changed files

➕ internal/database/migrations/mysql/0005_deleted_at.up.sql (+4 -0)
➕ internal/database/migrations/postgres/0002_deleted_at.up.sql (+4 -0)
➕ internal/database/migrations/sqlite/0004_deleted_at.up.sql (+4 -0)
📝 internal/database/mysql.go (+13 -0)
📝 internal/database/pg.go (+13 -0)
📝 internal/database/sqlite.go (+13 -0)

📄 Description

This PR will record deleted time with bookmark id in a seprate table.
any specific unit test needed?

Why we need this?

for create a sync functionality we need to have 3 things created_at modifieded_at and deleted_at
the last one added in this PR. as deleted_at use case is just for sync than keep that in separate table make things cleaner.

after merge #894 #896 and #903 i can finally send PR for add sync functionality to Shiori (some part of code is ready in local system). so user can sync their apps with Shiori server.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/903 **Author:** [@Monirzadeh](https://github.com/Monirzadeh) **Created:** 5/8/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `deleted_at` --- ### 📝 Commits (9) - [`093076d`](https://github.com/go-shiori/shiori/commit/093076dc904cf09dbe15d1e682f1ead5316f9211) add deleted table and record deleted_at inside that for sqlite - [`9f94610`](https://github.com/go-shiori/shiori/commit/9f94610d5fc90471995f11e3ec08c9a6de265fc6) add deleted table and record deleted_at inside that for postgres - [`bcc6ebf`](https://github.com/go-shiori/shiori/commit/bcc6ebf2ee86768927bd66163980dee6eb53d4a0) add deleted table and record deleted_at inside that for mariadb - [`9ff08a3`](https://github.com/go-shiori/shiori/commit/9ff08a37bbef70042e3bc5c51512a666d41e4fdd) Merge branch 'master' into deleted_at - [`9a8a0b8`](https://github.com/go-shiori/shiori/commit/9a8a0b843c981de54d6e6c76f1c93f290bcedcee) change migrate filename for sqlite - [`df57023`](https://github.com/go-shiori/shiori/commit/df57023689329936dfae738be6b933c61bcd1605) Merge branch 'deleted_at' of github.com:Monirzadeh/shiori into deleted_at - [`7b39432`](https://github.com/go-shiori/shiori/commit/7b394324bf923ae6c608bfa8ba50c37340218e52) fix golangci error - [`d79be9b`](https://github.com/go-shiori/shiori/commit/d79be9bea78f012484376c308c43457003f431f7) restore wrong file commit - [`aaf0d16`](https://github.com/go-shiori/shiori/commit/aaf0d162ba5b460307823437a5956312e7838027) Merge branch 'master' into deleted_at ### 📊 Changes **6 files changed** (+51 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `internal/database/migrations/mysql/0005_deleted_at.up.sql` (+4 -0) ➕ `internal/database/migrations/postgres/0002_deleted_at.up.sql` (+4 -0) ➕ `internal/database/migrations/sqlite/0004_deleted_at.up.sql` (+4 -0) 📝 `internal/database/mysql.go` (+13 -0) 📝 `internal/database/pg.go` (+13 -0) 📝 `internal/database/sqlite.go` (+13 -0) </details> ### 📄 Description This PR will record deleted time with bookmark id in a seprate table. any specific unit test needed? # Why we need this? for create a sync functionality we need to have 3 things `created_at` `modifieded_at` and `deleted_at` the last one added in this PR. as `deleted_at` use case is just for sync than keep that in separate table make things cleaner. after merge #894 #896 and #903 i can finally send PR for add sync functionality to Shiori (some part of code is ready in local system). so user can sync their apps with Shiori server. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>