[PR #885] [MERGED] feat: endpoint to serve readable content #841

Closed
opened 2026-02-25 23:35:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/885
Author: @Monirzadeh
Created: 4/8/2024
Status: Merged
Merged: 4/20/2024
Merged by: @fmartingr

Base: masterHead: dupicate-response


📝 Commits (10+)

  • 9e85a90 add endpoint to serve readable content
  • 59d0a06 Merge branch 'master' into dupicate-response
  • 846138a add id and modified time in response
  • 94ef851 revert id and modified time
  • 73d53a7 Merge branch 'master' into dupicate-response
  • 21664e0 remove public check status
  • f1289b2 chnage 401 to 403
  • 1d28d07 add basic unittest for readable content
  • 7aaa83d check response in unittest
  • a78ea69 Merge branch 'master' into dupicate-response

📊 Changes

5 files changed (+195 additions, -0 deletions)

View changed files

📝 docs/swagger/docs.go (+33 -0)
📝 docs/swagger/swagger.json (+33 -0)
📝 docs/swagger/swagger.yaml (+21 -0)
📝 internal/http/routes/api/v1/bookmarks.go (+58 -0)
📝 internal/http/routes/api/v1/bookmarks_test.go (+50 -0)

📄 Description

this Pull request serve readable content (text only and html) on /api/v1/bookmarks/id/readable

  • serve HTML and text of bookmarks
  • be sure it authenticate correctly
  • fix bug related to send duplicate response if user not authenticate
    bug found wait for fix
  • add unit test

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/885 **Author:** [@Monirzadeh](https://github.com/Monirzadeh) **Created:** 4/8/2024 **Status:** ✅ Merged **Merged:** 4/20/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `dupicate-response` --- ### 📝 Commits (10+) - [`9e85a90`](https://github.com/go-shiori/shiori/commit/9e85a90c81d9e0a9c8606709a94433231b3cc213) add endpoint to serve readable content - [`59d0a06`](https://github.com/go-shiori/shiori/commit/59d0a06312c194691a3558a8361ae706faaa7e44) Merge branch 'master' into dupicate-response - [`846138a`](https://github.com/go-shiori/shiori/commit/846138a1fb5ca5b2ad7976bbd4301fbe6e34ccb2) add id and modified time in response - [`94ef851`](https://github.com/go-shiori/shiori/commit/94ef851d0ed5d4bfc04d1f26e5c0ea822640ef52) revert id and modified time - [`73d53a7`](https://github.com/go-shiori/shiori/commit/73d53a73ccf6695e1f19d5146743abac3ba69822) Merge branch 'master' into dupicate-response - [`21664e0`](https://github.com/go-shiori/shiori/commit/21664e0e49acfce8763066bb64617cfef0b36a40) remove public check status - [`f1289b2`](https://github.com/go-shiori/shiori/commit/f1289b20e6260f23cb02d00c5f51cb06dc8d8d7c) chnage 401 to 403 - [`1d28d07`](https://github.com/go-shiori/shiori/commit/1d28d07a82f50a45b68b9e2748c3b1e30923df64) add basic unittest for readable content - [`7aaa83d`](https://github.com/go-shiori/shiori/commit/7aaa83dec21f4720dc9ab98118bd8d43e57d822d) check response in unittest - [`a78ea69`](https://github.com/go-shiori/shiori/commit/a78ea69c445eff7edeb43b34e626b654937f2fb5) Merge branch 'master' into dupicate-response ### 📊 Changes **5 files changed** (+195 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docs/swagger/docs.go` (+33 -0) 📝 `docs/swagger/swagger.json` (+33 -0) 📝 `docs/swagger/swagger.yaml` (+21 -0) 📝 `internal/http/routes/api/v1/bookmarks.go` (+58 -0) 📝 `internal/http/routes/api/v1/bookmarks_test.go` (+50 -0) </details> ### 📄 Description this Pull request serve readable content (text only and html) on `/api/v1/bookmarks/id/readable` - [x] serve HTML and text of bookmarks - [x] be sure it authenticate correctly - [x] fix bug related to send duplicate response if user not authenticate *bug found wait for fix* - [x] add unit test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:35:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#841
No description provided.