[PR #840] [MERGED] fix: update go-epub to latest version to avoid filename errors on windows #815

New issue

Closed

opened 2026-02-25 23:35:33 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/840
Author: @fmartingr
Created: 2/11/2024
Status: ✅ Merged
Merged: 2/13/2024
Merged by: @fmartingr

Base: master ← Head: fix/go-epub-auto-filename

📝 Commits (2)

351669e link to pr latest commit
208244d latest go-epub from main branch

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 go.mod (+2 -0)
📝 go.sum (+2 -2)

📄 Description

This PR will update to the last version of go-epub to fix filename generation errors on windows when using the EmbedImages method.

Right now it manually points to the PR to launch the CI on all operating systems, but when the bug is solved under go-epub our go.mod with point to a proper go-epub release version.

https://github.com/go-shiori/go-epub/issues/26

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/840 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 2/11/2024 **Status:** ✅ Merged **Merged:** 2/13/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix/go-epub-auto-filename` --- ### 📝 Commits (2) - [`351669e`](https://github.com/go-shiori/shiori/commit/351669e6e85c4c0362db09fed17ad1b5d8226625) link to pr latest commit - [`208244d`](https://github.com/go-shiori/shiori/commit/208244d6389d72dfa8a3e0bce66b5cef10b9a294) latest go-epub from main branch ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+2 -0) 📝 `go.sum` (+2 -2) </details> ### 📄 Description This PR will update to the last version of go-epub to fix filename generation errors on windows when using the [`EmbedImages`](https://pkg.go.dev/github.com/go-shiori/go-epub#Epub.EmbedImages) method. Right now it manually points to the PR to launch the CI on all operating systems, but when the bug is solved under go-epub our go.mod with point to a proper go-epub release version. https://github.com/go-shiori/go-epub/issues/26 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>