[PR #824] [CLOSED] ci: run tests in windows and macos too #805

Closed
opened 2026-02-25 23:35:31 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/824
Author: @fmartingr
Created: 1/26/2024
Status: Closed

Base: masterHead: ci/windows-macos


📝 Commits (6)

  • ac8433c ci: run tests in windows and macos too
  • 2a94c26 avoid testing mysql/psql in windows and macos
  • 95e0319 windows & macos matrix
  • 1737a89 disable gotestfmt
  • 0f65bfc replace which in shell script
  • f12ff1e handle error in test db removal

📊 Changes

6 files changed (+43 additions, -7 deletions)

View changed files

📝 .github/workflows/_test.yml (+30 -2)
📝 Makefile (+1 -1)
📝 internal/database/mysql_test.go (+3 -0)
📝 internal/database/pg_test.go (+3 -0)
📝 internal/database/sqlite_test.go (+4 -1)
📝 scripts/test.sh (+2 -3)

📄 Description

This PR experiments with the CI to run the test step in windows and macos too, to try and catch early any OS specific issues.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/824 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 1/26/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ci/windows-macos` --- ### 📝 Commits (6) - [`ac8433c`](https://github.com/go-shiori/shiori/commit/ac8433c182505226587b9f9858fcfb41d01459e5) ci: run tests in windows and macos too - [`2a94c26`](https://github.com/go-shiori/shiori/commit/2a94c26583f1d52c8906b579c5b7427f4b819d79) avoid testing mysql/psql in windows and macos - [`95e0319`](https://github.com/go-shiori/shiori/commit/95e03199e9947f02593ea671642a0744ae5f65e0) windows & macos matrix - [`1737a89`](https://github.com/go-shiori/shiori/commit/1737a893e26d2efd1e6de4ba88cb018b04ef8d22) disable gotestfmt - [`0f65bfc`](https://github.com/go-shiori/shiori/commit/0f65bfcb96c8d8376dda0ae60dc1dc42688ffaf7) replace which in shell script - [`f12ff1e`](https://github.com/go-shiori/shiori/commit/f12ff1e0948b0126f1c2c89e0d5fb73f6534bfa1) handle error in test db removal ### 📊 Changes **6 files changed** (+43 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/_test.yml` (+30 -2) 📝 `Makefile` (+1 -1) 📝 `internal/database/mysql_test.go` (+3 -0) 📝 `internal/database/pg_test.go` (+3 -0) 📝 `internal/database/sqlite_test.go` (+4 -1) 📝 `scripts/test.sh` (+2 -3) </details> ### 📄 Description This PR experiments with the CI to run the test step in windows and macos too, to try and catch early any OS specific issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:35:31 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#805
No description provided.