[PR #765] [MERGED] Make suggestions tapable/clickable #779

Closed
opened 2026-02-25 23:35:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/765
Author: @cbe
Created: 10/22/2023
Status: Merged
Merged: 10/29/2023
Merged by: @fmartingr

Base: masterHead: mobile_suggestions


📝 Commits (2)

  • 0c73646 Make suggestion clickable in bookmark creation
  • 99cd0ec Merge branch 'master' into mobile_suggestions

📊 Changes

1 file changed (+10 additions, -7 deletions)

View changed files

📝 internal/view/assets/js/component/dialog.js (+10 -7)

📄 Description

This was especially noticeable when using the web app on mobile devices as the suggestion looks like it's tapable. It should be also a little bit more convenient UX-wise when it's allowed to be clicked in non- mobile context as well.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/765 **Author:** [@cbe](https://github.com/cbe) **Created:** 10/22/2023 **Status:** ✅ Merged **Merged:** 10/29/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `mobile_suggestions` --- ### 📝 Commits (2) - [`0c73646`](https://github.com/go-shiori/shiori/commit/0c73646c50f4afe7e9333b27f945c4e112e36a68) Make suggestion clickable in bookmark creation - [`99cd0ec`](https://github.com/go-shiori/shiori/commit/99cd0ec06b3f18b0881849dd5e5c790ec5fae34f) Merge branch 'master' into mobile_suggestions ### 📊 Changes **1 file changed** (+10 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/assets/js/component/dialog.js` (+10 -7) </details> ### 📄 Description This was especially noticeable when using the web app on mobile devices as the suggestion looks like it's tapable. It should be also a little bit more convenient UX-wise when it's allowed to be clicked in non- mobile context as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:35:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#779
No description provided.