[PR #761] [MERGED] add create ebook by default in settings #777

Closed
opened 2026-02-25 23:35:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/761
Author: @Monirzadeh
Created: 10/15/2023
Status: Merged
Merged: 10/22/2023
Merged by: @fmartingr

Base: masterHead: generate-ebook-default-settings


📝 Commits (4)

  • dc96e3c add create ebook by default in settings
  • c838980 ebook automatic generate for new bookmark
  • ede6a27 fix empty ebook for new bookmark
  • 94f34ce Merge branch 'master' into generate-ebook-default-settings

📊 Changes

11 files changed (+30 additions, -0 deletions)

View changed files

📝 docs/swagger/docs.go (+3 -0)
📝 docs/swagger/swagger.json (+3 -0)
📝 docs/swagger/swagger.yaml (+2 -0)
📝 internal/core/processing.go (+1 -0)
📝 internal/http/routes/api/v1/auth_test.go (+2 -0)
📝 internal/model/account.go (+1 -0)
📝 internal/view/assets/js/page/home.js (+6 -0)
📝 internal/view/assets/js/page/setting.js (+5 -0)
📝 internal/view/content.html (+2 -0)
📝 internal/view/index.html (+2 -0)
📝 internal/webserver/handler-api.go (+3 -0)

📄 Description

add a settings for active generate ebook by default.

TODO:

  • add that to settings and work in update
  • create ebook work on add new bookmark
  • ebook should generate after constant is available (new bookmark create empty ebook right now)

What is not done in this PR

  • web extension and command line until we finish work on #369

fix #720


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/761 **Author:** [@Monirzadeh](https://github.com/Monirzadeh) **Created:** 10/15/2023 **Status:** ✅ Merged **Merged:** 10/22/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `generate-ebook-default-settings` --- ### 📝 Commits (4) - [`dc96e3c`](https://github.com/go-shiori/shiori/commit/dc96e3cf6304af605aed9bd517e83b4789511fff) add create ebook by default in settings - [`c838980`](https://github.com/go-shiori/shiori/commit/c838980d8d9cccc7f3a311d0bc47b6409d653844) ebook automatic generate for new bookmark - [`ede6a27`](https://github.com/go-shiori/shiori/commit/ede6a272396e4b4419b04e477efe8f14db9653af) fix empty ebook for new bookmark - [`94f34ce`](https://github.com/go-shiori/shiori/commit/94f34ce15f54d0e0caad02b34ddc81159353c32a) Merge branch 'master' into generate-ebook-default-settings ### 📊 Changes **11 files changed** (+30 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docs/swagger/docs.go` (+3 -0) 📝 `docs/swagger/swagger.json` (+3 -0) 📝 `docs/swagger/swagger.yaml` (+2 -0) 📝 `internal/core/processing.go` (+1 -0) 📝 `internal/http/routes/api/v1/auth_test.go` (+2 -0) 📝 `internal/model/account.go` (+1 -0) 📝 `internal/view/assets/js/page/home.js` (+6 -0) 📝 `internal/view/assets/js/page/setting.js` (+5 -0) 📝 `internal/view/content.html` (+2 -0) 📝 `internal/view/index.html` (+2 -0) 📝 `internal/webserver/handler-api.go` (+3 -0) </details> ### 📄 Description add a settings for active generate ebook by default. # TODO: - [x] add that to settings and work in update - [x] create ebook work on add new bookmark - [x] ebook should generate after constant is available ~~(new bookmark create empty ebook right now)~~ ## What is not done in this PR - web extension and command line until we finish work on #369 fix #720 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:35:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#777
No description provided.