[PR #759] [MERGED] fix: Actions in overlays on mobile hard to press #775

New issue

Closed

opened 2026-02-25 23:35:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/759
Author: @cbe
Created: 10/15/2023
Status: ✅ Merged
Merged: 10/22/2023
Merged by: @fmartingr

Base: master ← Head: mobile_overlays

📝 Commits (4)

51dd2fd fix: Actions in overlays on mobile hard to press
1f6f7ea Merge remote-tracking branch 'github' into mobile_overlays
d9c4326 fix: provide fallback values for newer dynamic viewport units
45fb8ee Merge branch 'master' into mobile_overlays

📊 Changes

3 files changed (+18 additions, -10 deletions)

View changed files

📝 internal/view/assets/css/style.css (+1 -1)
📝 internal/view/assets/less/common.less (+13 -7)
📝 internal/view/assets/less/custom-dialog.less (+4 -2)

📄 Description

Buttons on mobile devices could've been cut off, depending on the browsers chrome size which rendered them either completely off-screen or at least hard to reach. Using dvh (dynamic viewport height) should fix this issue for most newer browsers.

ℹ️ I could not find an issue for this problem, do you want me to create one so it's properly tracked?

Also: these types of units are rather new (stable since mid to end of last year, as seen on caniuse.com). What's your opinion on fallback values to the original vh for example?

Screenshots

`master`	with fix

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/759 **Author:** [@cbe](https://github.com/cbe) **Created:** 10/15/2023 **Status:** ✅ Merged **Merged:** 10/22/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `mobile_overlays` --- ### 📝 Commits (4) - [`51dd2fd`](https://github.com/go-shiori/shiori/commit/51dd2fd98b862f40db8b475f161acc1e0e6004aa) fix: Actions in overlays on mobile hard to press - [`1f6f7ea`](https://github.com/go-shiori/shiori/commit/1f6f7eafd05b24bf5beed43e108eb2a9fc8da957) Merge remote-tracking branch 'github' into mobile_overlays - [`d9c4326`](https://github.com/go-shiori/shiori/commit/d9c43268df21b46fe902e61671acca57acd47cfe) fix: provide fallback values for newer dynamic viewport units - [`45fb8ee`](https://github.com/go-shiori/shiori/commit/45fb8ee627eea2412d5e968ccb901fef11bd1bdb) Merge branch 'master' into mobile_overlays ### 📊 Changes **3 files changed** (+18 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/assets/css/style.css` (+1 -1) 📝 `internal/view/assets/less/common.less` (+13 -7) 📝 `internal/view/assets/less/custom-dialog.less` (+4 -2) </details> ### 📄 Description Buttons on mobile devices could've been cut off, depending on the browsers chrome size which rendered them either completely off-screen or at least hard to reach. Using `dvh` (dynamic viewport height) should fix this issue for most newer browsers. :information_source: I could not find an issue for this problem, do you want me to create one so it's properly tracked? Also: these types of units are rather new (stable since mid to end of last year, as seen on [caniuse.com](https://caniuse.com/viewport-unit-variants)). What's your opinion on fallback values to the original `vh` for example? ## Screenshots |`master`|with fix| | --- | --- | |![before](https://github.com/go-shiori/shiori/assets/2392330/9e346504-3078-446a-8142-2bd1fe5ffcd0)|![with-fix](https://github.com/go-shiori/shiori/assets/2392330/32f944b9-75cc-4610-b75e-16d359e91a0e)| --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>