[PR #747] [MERGED] fix: styles-check and swag-check monitor just needed directory not project root #769

Closed
opened 2026-02-25 23:35:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/747
Author: @Monirzadeh
Created: 10/3/2023
Status: Merged
Merged: 10/9/2023
Merged by: @fmartingr

Base: masterHead: fix-styles-check


📝 Commits (3)

  • 4b4cc75 styles-check just work on less and css directory
  • 3c85db6 just cheack css directory
  • edc010c make swag-check just monitor generated files

📊 Changes

2 files changed (+8 additions, -8 deletions)

View changed files

📝 scripts/styles_check.sh (+3 -3)
📝 scripts/swagger_check.sh (+5 -5)

📄 Description

currently if we use make styles-check or make swag-check those scripts return error if we have uncommit file even if they are not related to CSS or swagger.
this try to fix #737


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/747 **Author:** [@Monirzadeh](https://github.com/Monirzadeh) **Created:** 10/3/2023 **Status:** ✅ Merged **Merged:** 10/9/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix-styles-check` --- ### 📝 Commits (3) - [`4b4cc75`](https://github.com/go-shiori/shiori/commit/4b4cc750b9d5f4816ae81d4bcb662f5b9f723e0b) styles-check just work on less and css directory - [`3c85db6`](https://github.com/go-shiori/shiori/commit/3c85db66872445226d2fd464540e9df8704774f8) just cheack css directory - [`edc010c`](https://github.com/go-shiori/shiori/commit/edc010c9efe182fb22c7e2c8dbb10bb4f09738b6) make swag-check just monitor generated files ### 📊 Changes **2 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `scripts/styles_check.sh` (+3 -3) 📝 `scripts/swagger_check.sh` (+5 -5) </details> ### 📄 Description currently if we use `make styles-check` or `make swag-check` those scripts return error if we have uncommit file even if they are not related to CSS or swagger. this try to fix #737 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:35:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#769
No description provided.