[PR #679] [MERGED] refactor: Migrate ePub generation to go-epub #726

New issue

Closed

opened 2026-02-25 23:35:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/679
Author: @Monirzadeh
Created: 7/27/2023
Status: ✅ Merged
Merged: 9/16/2023
Merged by: @fmartingr

Base: master ← Head: fix-apple-books

📝 Commits (10+)

10a6275 fix apple books cannot import generated book with shiori fix #638
bb8c588 generate random content uuid for ebook fix #678
b61266e replace rand.Seed() with new method for golang 1.20
eb804bc update last master changes
49e8ba8 use go-epub to generate ebook
b6f4e16 add author and Description metadata
d7bab48 cleanup old code
cc4fbef remove unneeded unittests
17f0030 add url of bookmark to the end of ebook
73d6b72 add title to ebook

📊 Changes

4 files changed (+26 additions, -270 deletions)

View changed files

📝 go.mod (+3 -0)
📝 go.sum (+4 -0)
📝 internal/core/ebook.go (+19 -199)
📝 internal/core/ebook_test.go (+0 -71)

📄 Description

This pull request solves the problem in #638 and #678
Please before merge test that in real device. Based on your report and in my debug system, it should work fine.
we move to go-epub in this pull request that result of that
fix #638
fix #678
fix #688
fix #635

TODO:

add go-epub to requirement
Support RTL
update HTML to use included image
fix no reference image file. duplicate file included
update unit test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/679 **Author:** [@Monirzadeh](https://github.com/Monirzadeh) **Created:** 7/27/2023 **Status:** ✅ Merged **Merged:** 9/16/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix-apple-books` --- ### 📝 Commits (10+) - [`10a6275`](https://github.com/go-shiori/shiori/commit/10a6275e0ff6ad385c95fe615c279242352765b9) fix apple books cannot import generated book with shiori fix #638 - [`bb8c588`](https://github.com/go-shiori/shiori/commit/bb8c588d7e341d6c473255e22cc912ee96dde324) generate random content uuid for ebook fix #678 - [`b61266e`](https://github.com/go-shiori/shiori/commit/b61266e15c26720a1dd90120ca58268de4540881) replace rand.Seed() with new method for golang 1.20 - [`eb804bc`](https://github.com/go-shiori/shiori/commit/eb804bc003a26513075e18c449ba2c8897ed7bc3) update last master changes - [`49e8ba8`](https://github.com/go-shiori/shiori/commit/49e8ba8f28f18d2921814edbaa54e9cefd965035) use go-epub to generate ebook - [`b6f4e16`](https://github.com/go-shiori/shiori/commit/b6f4e16f83865e213d3c3a4aa09a67c301c41c4a) add author and Description metadata - [`d7bab48`](https://github.com/go-shiori/shiori/commit/d7bab48970852eb74cd45580a8624735101f1403) cleanup old code - [`cc4fbef`](https://github.com/go-shiori/shiori/commit/cc4fbef5b78ac82f2ed7c779401741c32459a818) remove unneeded unittests - [`17f0030`](https://github.com/go-shiori/shiori/commit/17f00300c080dc6f8baea85773c4eae4ae8d677f) add url of bookmark to the end of ebook - [`73d6b72`](https://github.com/go-shiori/shiori/commit/73d6b728ea79f2271dc1f69021a5c2550f76d76b) add title to ebook ### 📊 Changes **4 files changed** (+26 additions, -270 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+3 -0) 📝 `go.sum` (+4 -0) 📝 `internal/core/ebook.go` (+19 -199) 📝 `internal/core/ebook_test.go` (+0 -71) </details> ### 📄 Description This pull request solves the problem in #638 and #678 Please before merge test that in real device. Based on your report and in my debug system, it should work fine. we move to `go-epub` in this pull request that result of that fix #638 fix #678 fix #688 fix #635 ## TODO: - [x] add `go-epub` to requirement - [x] Support RTL - [x] update HTML to use included image - [x] fix no reference image file. duplicate file included - [x] update unit test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>