[PR #648] [MERGED] Run legacy API and new API at the same time. #715

New issue

Closed

opened 2026-02-25 23:35:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/648
Author: @fmartingr
Created: 7/18/2023
Status: ✅ Merged
Merged: 7/19/2023
Merged by: @fmartingr

Base: master ← Head: feat/api-v1-to-master

📝 Commits (10+)

6d897b6 config: backwards comptabile dir
fb81abd remove duplicated frontend
3a51281 frontend: move assets to assets folder
4674916 legacy routes handler in gin
f7be9f6 templates and asset in different embed
6338edb new routes
285e0c2 frontend routes serve old views
81c28a8 added DTO for account object
e19cd7a api auth calls legacy handler
f410e19 frontend: handle new error messages

📊 Changes

155 files changed (+761 additions, -24815 deletions)

View changed files

📝 .github/workflows/_buildx.yml (+18 -4)
➕ .github/workflows/_delete-registry-tag.yml (+14 -0)
📝 .github/workflows/docker/Dockerfile.ci (+1 -1)
📝 .github/workflows/pull_request.yml (+8 -1)
➕ .github/workflows/pull_request_closed.yml (+12 -0)
📝 .github/workflows/push.yml (+1 -0)
📝 .github/workflows/version_bump.yml (+6 -1)
📝 Dockerfile (+1 -1)
📝 Dockerfile.compose (+1 -1)
📝 README.md (+1 -1)
➕ docs/Storage.md (+14 -0)
📝 docs/index.md (+2 -1)
📝 internal/cmd/add.go (+5 -3)
📝 internal/cmd/check.go (+3 -1)
📝 internal/cmd/delete.go (+7 -5)
📝 internal/cmd/export.go (+3 -1)
📝 internal/cmd/import.go (+4 -2)
📝 internal/cmd/open.go (+4 -2)
📝 internal/cmd/pocket.go (+4 -2)
📝 internal/cmd/print.go (+3 -1)

...and 80 more files

📄 Description

Summary

Run the legacy API through the new gin API for un-migrated endpoints
Update the login to use the new API calls
- Workaround: Handle sessions the old way for the old endpoints to work. To be removed.
Add code logic to ensure there's an owner account present in the database (shiori/gopher)
Serve UI from the new routes
Remove debug routes
Use the new configuration and dependencies logic in all shiori commands
Refactored init logic into a function removing global variables
Updated docs
Updated CI/CD to also push tags for PR to easily test branches under pr-$NUMBER tag. Delete tags on PR close.

Fixes #439

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/648 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 7/18/2023 **Status:** ✅ Merged **Merged:** 7/19/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `feat/api-v1-to-master` --- ### 📝 Commits (10+) - [`6d897b6`](https://github.com/go-shiori/shiori/commit/6d897b64b0eb1d62f8731c8e5df951d58af89d5b) config: backwards comptabile dir - [`fb81abd`](https://github.com/go-shiori/shiori/commit/fb81abd5395d6b11f11270af3a8a422eb2367624) remove duplicated frontend - [`3a51281`](https://github.com/go-shiori/shiori/commit/3a51281f0b8566a680aae421b45d95eb7cca1b22) frontend: move assets to assets folder - [`4674916`](https://github.com/go-shiori/shiori/commit/467491623776578a22249df32d7202c4e69bbb1b) legacy routes handler in gin - [`f7be9f6`](https://github.com/go-shiori/shiori/commit/f7be9f6ef141c263f5887033ee045ba985c54e65) templates and asset in different embed - [`6338edb`](https://github.com/go-shiori/shiori/commit/6338edba05854ac88921a0792e1b496eb5878d36) new routes - [`285e0c2`](https://github.com/go-shiori/shiori/commit/285e0c2253ecb2c8b1cdec2fc7eee313f6514c19) frontend routes serve old views - [`81c28a8`](https://github.com/go-shiori/shiori/commit/81c28a8c21fea5117113a7a176a9f4deb2b66e61) added DTO for account object - [`e19cd7a`](https://github.com/go-shiori/shiori/commit/e19cd7a87e7f399e9acf48a3614aa0249fbb6fef) api auth calls legacy handler - [`f410e19`](https://github.com/go-shiori/shiori/commit/f410e19d87d5d950dadc39d017e2644138adbba5) frontend: handle new error messages ### 📊 Changes **155 files changed** (+761 additions, -24815 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/_buildx.yml` (+18 -4) ➕ `.github/workflows/_delete-registry-tag.yml` (+14 -0) 📝 `.github/workflows/docker/Dockerfile.ci` (+1 -1) 📝 `.github/workflows/pull_request.yml` (+8 -1) ➕ `.github/workflows/pull_request_closed.yml` (+12 -0) 📝 `.github/workflows/push.yml` (+1 -0) 📝 `.github/workflows/version_bump.yml` (+6 -1) 📝 `Dockerfile` (+1 -1) 📝 `Dockerfile.compose` (+1 -1) 📝 `README.md` (+1 -1) ➕ `docs/Storage.md` (+14 -0) 📝 `docs/index.md` (+2 -1) 📝 `internal/cmd/add.go` (+5 -3) 📝 `internal/cmd/check.go` (+3 -1) 📝 `internal/cmd/delete.go` (+7 -5) 📝 `internal/cmd/export.go` (+3 -1) 📝 `internal/cmd/import.go` (+4 -2) 📝 `internal/cmd/open.go` (+4 -2) 📝 `internal/cmd/pocket.go` (+4 -2) 📝 `internal/cmd/print.go` (+3 -1) _...and 80 more files_ </details> ### 📄 Description ## Summary - Run the legacy API through the new gin API for un-migrated endpoints - Update the login to use the new API calls - Workaround: Handle sessions the old way for the old endpoints to work. To be removed. - Add code logic to ensure there's an owner account present in the database (`shiori/gopher`) - Serve UI from the new routes - Remove debug routes - Use the new configuration and dependencies logic in all shiori commands - Refactored init logic into a function removing global variables - Updated docs - Updated CI/CD to also push tags for PR to easily test branches under `pr-$NUMBER` tag. Delete tags on PR close. Fixes #439 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>