[PR #646] [MERGED] fix download data image fix #645 #711

New issue

Closed

opened 2026-02-25 23:35:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/646
Author: @Monirzadeh
Created: 7/15/2023
Status: ✅ Merged
Merged: 7/15/2023
Merged by: @fmartingr

Base: master ← Head: fix-download-data-url

📝 Commits (1)

9601e4b fix download data image fix #645

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 internal/core/ebook.go (+3 -1)

📄 Description

This PR fix problem that download mechanism tried to get data/image.
It should not happen (they are not a real URL that point to the specific server, they are actual data)
by excluding them, we can handle data/image too.
Caliber or modern browser can handle this kind of links itself.
Will fix #645

for Future reference

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/646 **Author:** [@Monirzadeh](https://github.com/Monirzadeh) **Created:** 7/15/2023 **Status:** ✅ Merged **Merged:** 7/15/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix-download-data-url` --- ### 📝 Commits (1) - [`9601e4b`](https://github.com/go-shiori/shiori/commit/9601e4b00553ca02781355165c5d62cf55c0ddc0) fix download data image fix #645 ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/ebook.go` (+3 -1) </details> ### 📄 Description This PR fix problem that download mechanism tried to get data/image. It should not happen (they are not a real URL that point to the specific server, they are actual data) by excluding them, we can handle data/image too. Caliber or modern browser can handle this kind of links itself. Will fix #645 for [Future reference](https://en.wikipedia.org/wiki/Data_URI_scheme) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>