[GH-ISSUE #101] Ability to specify Listen-Address #71

New issue

Closed

opened 2026-02-25 23:33:23 +03:00 by kerem · 2 comments

kerem commented

2026-02-25 23:33:23 +03:00

Owner

Originally created by @contradictioned on GitHub (Jun 23, 2018).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/101

There is no way to specify a listen address (e.g., 127.0.0.1, or a specific public IP if you have multiple at hand). If I understand correctly, it is because the url for the HTTP-Server is set like here https://github.com/RadhiFadlillah/shiori/blob/master/cmd/serve/root.go#L60

Would you accept a PR where I introduce an option -l, --listen addr for specifying a listen address?

Originally created by @contradictioned on GitHub (Jun 23, 2018). Original GitHub issue: https://github.com/go-shiori/shiori/issues/101 There is no way to specify a listen address (e.g., 127.0.0.1, or a specific public IP if you have multiple at hand). If I understand correctly, it is because the url for the HTTP-Server is set like here https://github.com/RadhiFadlillah/shiori/blob/master/cmd/serve/root.go#L60 Would you accept a PR where I introduce an option `-l, --listen addr` for specifying a listen address?

kerem closed this issue

2026-02-25 23:33:23 +03:00

kerem commented

2026-02-25 23:33:23 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Jun 26, 2018):

Hi @contradictioned, sorry for late reply.

Would you accept a PR where I introduce an option -l, --listen addr for specifying a listen address?

Yes, feels free to do that, and thank you.

@RadhiFadlillah commented on GitHub (Jun 26, 2018): Hi @contradictioned, sorry for late reply. > Would you accept a PR where I introduce an option `-l, --listen addr` for specifying a listen address? Yes, feels free to do that, and thank you.

kerem commented

2026-02-25 23:33:23 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Aug 27, 2019):

Since the ramadhan branch is merged, the PR has been merged. However, I change the flag from -listen into -address because IMHO it's more clear.

Since it has been implemented, I will close this issue. Feels free to reopen it if needed.

@RadhiFadlillah commented on GitHub (Aug 27, 2019): Since the `ramadhan` branch is merged, the PR has been merged. However, I change the flag from `-listen` into `-address` because IMHO it's more clear. Since it has been implemented, I will close this issue. Feels free to reopen it if needed.