mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[PR #636] [MERGED] fix: prevent bookmark overwrite on archive download #707
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#707
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/go-shiori/shiori/pull/636
Author: @fmartingr
Created: 7/8/2023
Status: ✅ Merged
Merged: 7/9/2023
Merged by: @fmartingr
Base:
master← Head:fmartingr/issue632📝 Commits (2)
4127adefix: prevent bookmark overwrite on downloadaeee1a2Merge branch 'master' into fmartingr/issue632📊 Changes
1 file changed (+5 additions, -3 deletions)
View changed files
📝
internal/webserver/handler-api.go(+5 -3)📄 Description
This checks if the bookmark has a custom title and excerpt when calling the content download to preserve the custom attributes instead of overwriting them.
Fixes #632
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.