mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[PR #561] [CLOSED] fix(frontend): avoid night mode flickering on reload #666
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#666
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/go-shiori/shiori/pull/561
Author: @sdvcrx
Created: 1/29/2023
Status: ❌ Closed
Base:
master← Head:fix/night-mode📝 Commits (1)
1398489fix(frontend): avoid night mode flickering on reload📊 Changes
2 files changed (+18 additions, -7 deletions)
View changed files
📝
internal/view/content.html(+8 -3)📝
internal/view/index.html(+10 -4)📄 Description
Hi!
Shiori pages are flickering on refresh(or initialize), you can watch the video below.
https://user-images.githubusercontent.com/5170232/215329259-f1d02b9a-3899-480e-bb44-3038a23f3a13.mp4
This patch can fix it by moving nightMode related code to
<head>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.