[PR #554] [MERGED] feat: improve bookmark image detection #662

New issue

Closed

opened 2026-02-25 23:35:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/554
Author: @Katarn
Created: 1/12/2023
Status: ✅ Merged
Merged: 1/21/2023
Merged by: @fmartingr

Base: master ← Head: feat/improve-bookmark-image-detection

📝 Commits (1)

7c43073 feat: improve bookmark image detection

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 internal/core/processing.go (+5 -1)

📄 Description

Unfortunately, not all web servers are configured correctly. I found a detailed comment on Stack Overflow from which it becomes clear that the MIME type image/jpg does not exist. But I am faced with the fact that on some servers, however, this type is specified. And as a result, the cover does not load.

Here is an example of a link: https://vc.ru/581066

$ curl -I -X GET "https://vc.ru/cover/fb/c/581066/1673501221/cover.jpg"

HTTP/2 200
content-type: image/jpg

Before and after this change:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/554 **Author:** [@Katarn](https://github.com/Katarn) **Created:** 1/12/2023 **Status:** ✅ Merged **Merged:** 1/21/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `feat/improve-bookmark-image-detection` --- ### 📝 Commits (1) - [`7c43073`](https://github.com/go-shiori/shiori/commit/7c43073e159acae0ce2bb54d9709fd3489aba706) feat: improve bookmark image detection ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/processing.go` (+5 -1) </details> ### 📄 Description Unfortunately, not all web servers are configured correctly. I found a [detailed comment on Stack Overflow](https://stackoverflow.com/a/54488403) from which it becomes clear that the MIME type `image/jpg` does not exist. But I am faced with the fact that on some servers, however, this type is specified. And as a result, the cover does not load. Here is an example of a link: https://vc.ru/581066 ```bash $ curl -I -X GET "https://vc.ru/cover/fb/c/581066/1673501221/cover.jpg" HTTP/2 200 content-type: image/jpg ``` Before and after this change: ![изображение](https://user-images.githubusercontent.com/6339978/212035927-73be752b-af67-47aa-82bc-954f2b4d3283.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>