[PR #520] [MERGED] fix: remove createnewid usages #639

New issue

Closed

opened 2026-02-25 23:34:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/520
Author: @fmartingr
Created: 10/15/2022
Status: ✅ Merged
Merged: 10/15/2022
Merged by: @fmartingr

Base: master ← Head: issue-271

📝 Commits (3)

b51e37a remove CreateNewID usages
74a0bb5 remove CreateNewID implementations and definition
9ebfdd3 added missing sqlite envvar to compose file

📊 Changes

9 files changed (+102 additions, -86 deletions)

View changed files

📝 docker-compose.yaml (+1 -0)
📝 internal/cmd/add.go (+19 -17)
📝 internal/cmd/import.go (+0 -9)
📝 internal/cmd/pocket.go (+0 -9)
📝 internal/database/database.go (+0 -3)
📝 internal/database/database_test.go (+82 -0)
📝 internal/database/mysql.go (+0 -14)
📝 internal/database/pg.go (+0 -13)
📝 internal/database/sqlite.go (+0 -21)

📄 Description

This pull request removes the definition, implementation and usage of CreateNewID now that the SaveBookmarks implementation differentiates between a creation and a deletion, and make the creation homogenous between the CLI and the API, though not using common code for now.

Fixes #271

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/520 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 10/15/2022 **Status:** ✅ Merged **Merged:** 10/15/2022 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `issue-271` --- ### 📝 Commits (3) - [`b51e37a`](https://github.com/go-shiori/shiori/commit/b51e37a47e920d02d948c109bd8a82c2cde58e06) remove CreateNewID usages - [`74a0bb5`](https://github.com/go-shiori/shiori/commit/74a0bb56b0b0f2e8a31b80f12b12cd430aeb8228) remove CreateNewID implementations and definition - [`9ebfdd3`](https://github.com/go-shiori/shiori/commit/9ebfdd35d96e6361092b8c7416a767a4c0d8250b) added missing sqlite envvar to compose file ### 📊 Changes **9 files changed** (+102 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `docker-compose.yaml` (+1 -0) 📝 `internal/cmd/add.go` (+19 -17) 📝 `internal/cmd/import.go` (+0 -9) 📝 `internal/cmd/pocket.go` (+0 -9) 📝 `internal/database/database.go` (+0 -3) 📝 `internal/database/database_test.go` (+82 -0) 📝 `internal/database/mysql.go` (+0 -14) 📝 `internal/database/pg.go` (+0 -13) 📝 `internal/database/sqlite.go` (+0 -21) </details> ### 📄 Description This pull request removes the definition, implementation and usage of `CreateNewID` now that the `SaveBookmarks` implementation differentiates between a creation and a deletion, and make the creation homogenous between the CLI and the API, though not using common code for now. Fixes #271 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>