[PR #513] [MERGED] fix: avoid panic usage when downloading bookmark #633

New issue

Closed

opened 2026-02-25 23:34:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/513
Author: @fmartingr
Created: 10/12/2022
Status: ✅ Merged
Merged: 10/14/2022
Merged by: @fmartingr

Base: master ← Head: issue-459

📝 Commits (1)

24be4e1 fix: avoid panic usage when downloading bookmark

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 internal/webserver/handler-api.go (+4 -4)

📄 Description

Removed the usage of panic() when downloading a bookmark and simply return an error that has to be checked by implementations.

Right now the API will continue if the bookmark download fails (either sync or async) but will leave a log with the error cause, so the users have the bookmark stored even if the archival didn't actually happen (but can be done manually later on).

Fixes #459
Closes #495 (I actually forgot about this PR, sorry)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/513 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 10/12/2022 **Status:** ✅ Merged **Merged:** 10/14/2022 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `issue-459` --- ### 📝 Commits (1) - [`24be4e1`](https://github.com/go-shiori/shiori/commit/24be4e14cb2759c8f5d27997242ab4d157552ea4) fix: avoid panic usage when downloading bookmark ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `internal/webserver/handler-api.go` (+4 -4) </details> ### 📄 Description Removed the usage of `panic()` when downloading a bookmark and simply return an error that has to be checked by implementations. Right now the API will continue if the bookmark download fails (either sync or async) but will leave a log with the error cause, so the users have the bookmark stored even if the archival didn't actually happen (but can be done manually later on). Fixes #459 Closes #495 (I actually forgot about this PR, sorry) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>