[PR #490] [MERGED] fix: import should respect add_date or last_modified fields #614

New issue

Closed

opened 2026-02-25 23:34:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/490
Author: @fmartingr
Created: 10/7/2022
Status: ✅ Merged
Merged: 10/9/2022
Merged by: @fmartingr

Base: master ← Head: issue-121

📝 Commits (3)

e4a048d fix: handle last_modified and add_date in imports
235c860 refactor: moved date format to a constant
1afba2e fix: use provided modified date when set

📊 Changes

7 files changed (+43 additions, -14 deletions)

View changed files

📝 internal/cmd/export.go (+2 -1)
📝 internal/cmd/import.go (+24 -5)
📝 internal/cmd/pocket.go (+1 -1)
📝 internal/database/mysql.go (+4 -2)
📝 internal/database/pg.go (+4 -2)
📝 internal/database/sqlite.go (+5 -3)
➕ internal/model/const.go (+3 -0)

📄 Description

Import command now respects the ADD_DATE or LAST_MODIFIED field, with the latter taking priority.
Fixed a bug where saving a bookmarks would always set the modified date to the current date instead of using the set modified on the bookmark.

Fixes #121

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/490 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 10/7/2022 **Status:** ✅ Merged **Merged:** 10/9/2022 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `issue-121` --- ### 📝 Commits (3) - [`e4a048d`](https://github.com/go-shiori/shiori/commit/e4a048d75cf03d31f9280da97851a1749d91327e) fix: handle last_modified and add_date in imports - [`235c860`](https://github.com/go-shiori/shiori/commit/235c8608a38c74c692fe95ef0a8163208af038e9) refactor: moved date format to a constant - [`1afba2e`](https://github.com/go-shiori/shiori/commit/1afba2e942de0ec7759d1356ca7306c793f14744) fix: use provided modified date when set ### 📊 Changes **7 files changed** (+43 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/export.go` (+2 -1) 📝 `internal/cmd/import.go` (+24 -5) 📝 `internal/cmd/pocket.go` (+1 -1) 📝 `internal/database/mysql.go` (+4 -2) 📝 `internal/database/pg.go` (+4 -2) 📝 `internal/database/sqlite.go` (+5 -3) ➕ `internal/model/const.go` (+3 -0) </details> ### 📄 Description - Import command now respects the `ADD_DATE` or `LAST_MODIFIED` field, with the latter taking priority. - Fixed a bug where saving a bookmarks would always set the modified date to the current date instead of using the set modified on the bookmark. Fixes #121 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>