[PR #487] [MERGED] fix(import): check for no rows error #611

New issue

Closed

opened 2026-02-25 23:34:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/487
Author: @fmartingr
Created: 10/4/2022
Status: ✅ Merged
Merged: 10/4/2022
Merged by: @fmartingr

Base: master ← Head: issue-483

📝 Commits (1)

a3d6e0a fix(import): check for no rows error

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 internal/cmd/import.go (+3 -1)

📄 Description

Check if the error from the GetBookmark call is database.ErrNoRows (query not returning results) and ignore it, allowing the importer to create the missing bookmarks.

Fixes #483

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/487 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 10/4/2022 **Status:** ✅ Merged **Merged:** 10/4/2022 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `issue-483` --- ### 📝 Commits (1) - [`a3d6e0a`](https://github.com/go-shiori/shiori/commit/a3d6e0ad1044ca6afab6c993e24371813c8d87ec) fix(import): check for no rows error ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/import.go` (+3 -1) </details> ### 📄 Description Check if the error from the `GetBookmark` call is `database.ErrNoRows` (query not returning results) and ignore it, allowing the importer to create the missing bookmarks. Fixes #483 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>