[PR #467] [CLOSED] draft: logic domains #604

New issue

Closed

opened 2026-02-25 23:34:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/467
Author: @fmartingr
Created: 8/10/2022
Status: ❌ Closed

Base: master ← Head: draft/domains

📝 Commits (1)

2af9af3 wip: domains

📊 Changes

7 files changed (+30 additions, -1 deletions)

View changed files

➕ internal/domain/accounts.go (+1 -0)
➕ internal/domain/auth.go (+1 -0)
➕ internal/domain/bookmarks.go (+1 -0)
➕ internal/domain/tags.go (+20 -0)
📝 internal/webserver/handler-api.go (+1 -1)
📝 internal/webserver/handler.go (+3 -0)
📝 internal/webserver/server.go (+3 -0)

📄 Description

A draft pull request to explain and experiment with logic domains, to try and encapsulate the common code between the API and the CLI prior to API improvements (#466)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/467 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 8/10/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `draft/domains` --- ### 📝 Commits (1) - [`2af9af3`](https://github.com/go-shiori/shiori/commit/2af9af3fac62e6e1b98095c4ef9496308089e8bb) wip: domains ### 📊 Changes **7 files changed** (+30 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `internal/domain/accounts.go` (+1 -0) ➕ `internal/domain/auth.go` (+1 -0) ➕ `internal/domain/bookmarks.go` (+1 -0) ➕ `internal/domain/tags.go` (+20 -0) 📝 `internal/webserver/handler-api.go` (+1 -1) 📝 `internal/webserver/handler.go` (+3 -0) 📝 `internal/webserver/server.go` (+3 -0) </details> ### 📄 Description A draft pull request to explain and experiment with logic domains, to try and encapsulate the common code between the API and the CLI prior to API improvements (#466) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>