[PR #452] [CLOSED] fixbug: the bookmark Primary key also auto increment when insert false. #603

Closed
opened 2026-02-25 23:34:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/452
Author: @Schr0dingerCat
Created: 7/25/2022
Status: Closed

Base: masterHead: master


📝 Commits (1)

  • 952fbc3 fixbug: the bookmark Primary key also auto increment when insert false.

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 internal/database/pg.go (+6 -1)

📄 Description

fixbug: the bookmark Primary key also auto increment when insert false.so after upsert or insert, we need get the right bookmark id with the url. so you are not sure the bookmark id before you insert sucessfully into bookmark table. you shoud get the id after insert sucessfully


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/452 **Author:** [@Schr0dingerCat](https://github.com/Schr0dingerCat) **Created:** 7/25/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`952fbc3`](https://github.com/go-shiori/shiori/commit/952fbc31e7e809b43ef7b9c004f96b6338fa6cbc) fixbug: the bookmark Primary key also auto increment when insert false. ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/database/pg.go` (+6 -1) </details> ### 📄 Description fixbug: the bookmark Primary key also auto increment when insert false.so after upsert or insert, we need get the right bookmark id with the url. so you are not sure the bookmark id before you insert sucessfully into bookmark table. you shoud get the id after insert sucessfully --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:34:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#603
No description provided.