[PR #437] [MERGED] feat: session expire time from backend #596

New issue

Closed

opened 2026-02-25 23:34:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/437
Author: @fmartingr
Created: 6/23/2022
Status: ✅ Merged
Merged: 7/23/2022
Merged by: @fmartingr

Base: master ← Head: feat/session-from-backend

📝 Commits (2)

dd54c12 feat: session expire time from backend
b86c416 chore: remove test logger

📊 Changes

2 files changed (+3 additions, -4 deletions)

View changed files

📝 internal/view/login.html (+1 -3)
📝 internal/webserver/handler-api.go (+2 -1)

📄 Description

Deduplicated logic from backend and frontend where we needed to take the
login checkbox into account for both back and front codebases. Now the
backend will send the frontend the expire time calculated only in one
place.

This is part of a multi-step process that will store sessions in
database, but this will ease the maintenance of this section for now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/437 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 6/23/2022 **Status:** ✅ Merged **Merged:** 7/23/2022 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `feat/session-from-backend` --- ### 📝 Commits (2) - [`dd54c12`](https://github.com/go-shiori/shiori/commit/dd54c1216f7d13d248606fe9b6cd14b99d87c1a1) feat: session expire time from backend - [`b86c416`](https://github.com/go-shiori/shiori/commit/b86c416e728326bf2a6cc8cce019584720a9417e) chore: remove test logger ### 📊 Changes **2 files changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/login.html` (+1 -3) 📝 `internal/webserver/handler-api.go` (+2 -1) </details> ### 📄 Description Deduplicated logic from backend and frontend where we needed to take the login checkbox into account for both back and front codebases. Now the backend will send the frontend the expire time calculated only in one place. This is part of a multi-step process that will store sessions in database, but this will ease the maintenance of this section for now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>