mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #84] Feature request : Add a bookmarklet to add a page to shiori directly by cliking on a bookmarklet on a given page. #59
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#59
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gissehel on GitHub (Apr 9, 2018).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/84
Add a bookmarklet to add a page to shiori directly by cliking on a bookmarklet on a given page.
Expected usage
javascript:(function(){...})()@RadhiFadlillah commented on GitHub (Jun 5, 2018):
Hi guys, sorry for late response.
I've made a simple bookmarklet for
shiorithat works by sending POST request to$SHIORI/api/bookmarksthroughXMLHttpRequest. The problem is this only works if$SHIORIis HTTPs, because the modern web browser now blocks all active mixed content.Now, since
shioriis self hosted, not all user can serve it behind HTTPs. To solve it, as the fallback when$SHIORIis not HTTPs, I'm planning to make the bookmarklet redirects user to submit page$SHIORI/submit?url=...(just like Reddit's submit page).If all goes well this feature should be committed on these following days.
@5hay commented on GitHub (Jun 5, 2018):
Since you can get a SSL certificate pretty easily and for free through LetsEncrypt, you could maybe integrate auto certificate renewal.
https://godoc.org/golang.org/x/crypto/acme/autocert as a reference.
I think most shiori instances are available over the internet, that's why I would definitely recommend a SSL certificate.
@RadhiFadlillah commented on GitHub (Jun 6, 2018):
I've added bookmarklet in commit
4b93937. To use it, just drag theAdd new bookmarkbutton to your bookmark toolbar :When possible (i.e. allowed by CSP), the bookmarklet will show dialog for saving new bookmark :
However, if it's not possible, the bookmarklet will redirect you to submit page :
Please try it out.
I don't think I will do it, because :
shiori. Right now I just want to focus on making shiori stable and reliable enough to use.shiori, they usually put it behind a web server anyway, and there are already many good web server that can fetch SSL certificate from Let'sEncrypt, e.g Caddy and nginx.@5hay commented on GitHub (Jun 6, 2018):
Works pretty nice, running behind a Nginx reverse proxy on my Raspberry Pi via Docker. Thank you!
@gissehel commented on GitHub (Jun 16, 2018):
As it works fine, I'll close the issue.
@imjoeyli commented on GitHub (Nov 24, 2019):
It doesn't work now? The add button can't drag and drop.
@jajpater commented on GitHub (May 27, 2020):
Doesn't work here either
@8bitgentleman commented on GitHub (May 27, 2020):
The bookmarklet has been depreciated and the official method is now the web extension
@jajpater commented on GitHub (May 28, 2020):
@8bitgentleman I know, but that didn't work for me either see this issue