[PR #368] [MERGED] feat: async content download when creating via api #577

New issue

Closed

opened 2026-02-25 23:34:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/368
Author: @fmartingr
Created: 2/13/2022
Status: ✅ Merged
Merged: 2/13/2022
Merged by: @fmartingr

Base: master ← Head: feat/async-add

📝 Commits (3)

b936dff feat: async content download when creating via api
1d5c8dd fix: fetch only if async field is true
9717c4a revert: api extension api

📊 Changes

3 files changed (+74 additions, -25 deletions)

View changed files

📝 internal/core/processing.go (+4 -4)
📝 internal/webserver/handler-api-ext.go (+4 -0)
📝 internal/webserver/handler-api.go (+66 -21)

📄 Description

Added an async field to POST /api/bookmark to allow the fetching of the bookmarks content to be asynchronous. The bookmarks updated content (thumbnail and so) will only be shown in the frontend after a refresh.

Along with that, the extension API call has been left untouched since I wasn't able to test it. We need to fix #269 before improving the webextension support.

Fixes: #302
Blocked by: #367

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/368 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 2/13/2022 **Status:** ✅ Merged **Merged:** 2/13/2022 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `feat/async-add` --- ### 📝 Commits (3) - [`b936dff`](https://github.com/go-shiori/shiori/commit/b936dff2ba571bdcdda3d449c06f7a3e8381beff) feat: async content download when creating via api - [`1d5c8dd`](https://github.com/go-shiori/shiori/commit/1d5c8dd070b997fcf21ba04f58150a86a074f715) fix: fetch only if async field is true - [`9717c4a`](https://github.com/go-shiori/shiori/commit/9717c4a3f7d739253c0a984c1f65529d0448282f) revert: api extension api ### 📊 Changes **3 files changed** (+74 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/processing.go` (+4 -4) 📝 `internal/webserver/handler-api-ext.go` (+4 -0) 📝 `internal/webserver/handler-api.go` (+66 -21) </details> ### 📄 Description Added an `async` field to POST /api/bookmark to allow the fetching of the bookmarks content to be asynchronous. The bookmarks updated content (thumbnail and so) will only be shown in the frontend after a refresh. Along with that, the extension API call has been left untouched since I wasn't able to test it. We need to fix #269 before improving the webextension support. Fixes: #302 Blocked by: #367 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>