[PR #366] [MERGED] fix: lint errors #574

New issue

Closed

opened 2026-02-25 23:34:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/366
Author: @fmartingr
Created: 2/13/2022
Status: ✅ Merged
Merged: 2/13/2022
Merged by: @fmartingr

Base: master ← Head: fix/lint

📝 Commits (2)

248a3ad fix: lint errors
edbae73 fix: errcheck

📊 Changes

8 files changed (+141 additions, -83 deletions)

View changed files

📝 internal/cmd/export.go (+3 -1)
📝 internal/cmd/utils.go (+11 -13)
📝 internal/core/processing.go (+1 -1)
📝 internal/database/mysql.go (+24 -8)
📝 internal/database/pg.go (+36 -21)
📝 internal/database/sqlite.go (+46 -30)
📝 internal/webserver/handler-api.go (+1 -3)
📝 internal/webserver/handler-ui.go (+19 -6)

📄 Description

Fixed all offending code from a golangci-lint run so the future CI (#365) works on master without errors.

Most errcheck conditions have been done without modifications to the current workflow to avoid any new bugs except on those that clearly failed at the point of the error.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/366 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 2/13/2022 **Status:** ✅ Merged **Merged:** 2/13/2022 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix/lint` --- ### 📝 Commits (2) - [`248a3ad`](https://github.com/go-shiori/shiori/commit/248a3ad268bff3af67494d5ba87e9aba84cc3518) fix: lint errors - [`edbae73`](https://github.com/go-shiori/shiori/commit/edbae73166a7996cd88438a35d5ed324e9b61571) fix: errcheck ### 📊 Changes **8 files changed** (+141 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/export.go` (+3 -1) 📝 `internal/cmd/utils.go` (+11 -13) 📝 `internal/core/processing.go` (+1 -1) 📝 `internal/database/mysql.go` (+24 -8) 📝 `internal/database/pg.go` (+36 -21) 📝 `internal/database/sqlite.go` (+46 -30) 📝 `internal/webserver/handler-api.go` (+1 -3) 📝 `internal/webserver/handler-ui.go` (+19 -6) </details> ### 📄 Description Fixed all offending code from a golangci-lint run so the future CI (#365) works on master without errors. Most `errcheck` conditions have been done without modifications to the current workflow to avoid any new bugs except on those that clearly failed at the point of the error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>