[PR #259] [MERGED] Exit with non-zero status when commands fail #552

New issue

Closed

opened 2026-02-25 23:34:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/259
Author: @deanishe
Created: 8/6/2020
Status: ✅ Merged
Merged: 8/6/2020
Merged by: @deanishe

Base: master ← Head: fix/exit-status

📝 Commits (1)

a0ce725 Exit with non-zero status when add fails

📊 Changes

8 files changed (+46 additions, -29 deletions)

View changed files

📝 internal/cmd/check.go (+7 -4)
📝 internal/cmd/delete.go (+2 -2)
📝 internal/cmd/export.go (+3 -3)
📝 internal/cmd/import.go (+4 -4)
📝 internal/cmd/open.go (+16 -7)
📝 internal/cmd/pocket.go (+3 -3)
📝 internal/cmd/print.go (+2 -1)
📝 internal/cmd/update.go (+9 -5)

📄 Description

Replace return with os.Exit(1) as appropriate.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/259 **Author:** [@deanishe](https://github.com/deanishe) **Created:** 8/6/2020 **Status:** ✅ Merged **Merged:** 8/6/2020 **Merged by:** [@deanishe](https://github.com/deanishe) **Base:** `master` ← **Head:** `fix/exit-status` --- ### 📝 Commits (1) - [`a0ce725`](https://github.com/go-shiori/shiori/commit/a0ce72516748aa379550b7cb81f55979b6eb3366) Exit with non-zero status when add fails ### 📊 Changes **8 files changed** (+46 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/check.go` (+7 -4) 📝 `internal/cmd/delete.go` (+2 -2) 📝 `internal/cmd/export.go` (+3 -3) 📝 `internal/cmd/import.go` (+4 -4) 📝 `internal/cmd/open.go` (+16 -7) 📝 `internal/cmd/pocket.go` (+3 -3) 📝 `internal/cmd/print.go` (+2 -1) 📝 `internal/cmd/update.go` (+9 -5) </details> ### 📄 Description Replace `return` with `os.Exit(1)` as appropriate. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>