[PR #250] [CLOSED] Sql #547

New issue

Closed

opened 2026-02-25 23:34:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/250
Author: @ynsta
Created: 5/19/2020
Status: ❌ Closed

Base: master ← Head: sql

📝 Commits (2)

9b56638 🐛Fix bug on bookmark insert for pgsql
0f37604 🐛Remove invalid UTF8 runes in strings before db insert

📊 Changes

4 files changed (+78 additions, -40 deletions)

View changed files

📝 internal/database/database.go (+12 -0)
📝 internal/database/mysql.go (+10 -3)
📝 internal/database/pg.go (+31 -31)
📝 internal/database/sqlite.go (+25 -6)

📄 Description

Hello,

Two commit to solve issues encountered using shiori with postgresql.

The serial auto increment was not working, and made a constraint violation for all bookmarks insertions after a delete. I also improved auto tag bookmark relation deletion with an on cascade delete.

The second commit is the removal of all invalid runes for utf8 before inserting in the db as it caused an error with pg.

Note that it might mask a bug in another part of the programs on the validity of the fetched bookmark content.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/250 **Author:** [@ynsta](https://github.com/ynsta) **Created:** 5/19/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `sql` --- ### 📝 Commits (2) - [`9b56638`](https://github.com/go-shiori/shiori/commit/9b566382a600d4e9bd83fa71f32f3e021fac2ecc) 🐛Fix bug on bookmark insert for pgsql - [`0f37604`](https://github.com/go-shiori/shiori/commit/0f376042b55e5bbc55ed2966e3372646f42325ca) 🐛Remove invalid UTF8 runes in strings before db insert ### 📊 Changes **4 files changed** (+78 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `internal/database/database.go` (+12 -0) 📝 `internal/database/mysql.go` (+10 -3) 📝 `internal/database/pg.go` (+31 -31) 📝 `internal/database/sqlite.go` (+25 -6) </details> ### 📄 Description Hello, Two commit to solve issues encountered using shiori with postgresql. The serial auto increment was not working, and made a constraint violation for all bookmarks insertions after a delete. I also improved auto tag bookmark relation deletion with an on cascade delete. The second commit is the removal of all invalid runes for utf8 before inserting in the db as it caused an error with pg. Note that it might mask a bug in another part of the programs on the validity of the fetched bookmark content. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>