[PR #224] [CLOSED] Make "add" command exit with non-zero status when it fails #542

New issue

Closed

opened 2026-02-25 23:34:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/224
Author: @deanishe
Created: 12/13/2019
Status: ❌ Closed

Base: master ← Head: fix/exit-on-error

📝 Commits (2)

a5cb2c6 Fix login autofill
a63ea5d Exit with non-zero status when add fails

📊 Changes

3 files changed (+93 additions, -86 deletions)

View changed files

📝 internal/cmd/add.go (+5 -4)
📝 internal/view/login.html (+26 -20)
📝 internal/webserver/assets-prod.go (+62 -62)

📄 Description

Make shiori add exit with non-zero status when adding the bookmark fails. Fixes #225

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/224 **Author:** [@deanishe](https://github.com/deanishe) **Created:** 12/13/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/exit-on-error` --- ### 📝 Commits (2) - [`a5cb2c6`](https://github.com/go-shiori/shiori/commit/a5cb2c6e40063277c0b5eb9ee8a92ddfd044b069) Fix login autofill - [`a63ea5d`](https://github.com/go-shiori/shiori/commit/a63ea5de36ff3b78e16b09a510a735e3a81fbe8a) Exit with non-zero status when add fails ### 📊 Changes **3 files changed** (+93 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/add.go` (+5 -4) 📝 `internal/view/login.html` (+26 -20) 📝 `internal/webserver/assets-prod.go` (+62 -62) </details> ### 📄 Description Make `shiori add` exit with non-zero status when adding the bookmark fails. Fixes #225 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>