[PR #223] [MERGED] Specify charset for MySQL connection #540

Closed
opened 2026-02-25 23:34:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/223
Author: @deanishe
Created: 12/13/2019
Status: Merged
Merged: 8/6/2020
Merged by: @deanishe

Base: masterHead: fix/mysql-charset


📝 Commits (2)

  • a5cb2c6 Fix login autofill
  • 32f9d26 Explicit charset for MySQL connection

📊 Changes

4 files changed (+99 additions, -93 deletions)

View changed files

📝 internal/cmd/root.go (+1 -1)
📝 internal/database/mysql.go (+10 -10)
📝 internal/view/login.html (+26 -20)
📝 internal/webserver/assets-prod.go (+62 -62)

📄 Description

Also specify charset for the connection. Full fix for #188.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/223 **Author:** [@deanishe](https://github.com/deanishe) **Created:** 12/13/2019 **Status:** ✅ Merged **Merged:** 8/6/2020 **Merged by:** [@deanishe](https://github.com/deanishe) **Base:** `master` ← **Head:** `fix/mysql-charset` --- ### 📝 Commits (2) - [`a5cb2c6`](https://github.com/go-shiori/shiori/commit/a5cb2c6e40063277c0b5eb9ee8a92ddfd044b069) Fix login autofill - [`32f9d26`](https://github.com/go-shiori/shiori/commit/32f9d2695f76637dd8876c171b5ba98d4c7cd4b7) Explicit charset for MySQL connection ### 📊 Changes **4 files changed** (+99 additions, -93 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/root.go` (+1 -1) 📝 `internal/database/mysql.go` (+10 -10) 📝 `internal/view/login.html` (+26 -20) 📝 `internal/webserver/assets-prod.go` (+62 -62) </details> ### 📄 Description Also specify charset for the connection. Full fix for #188. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:34:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#540
No description provided.