[PR #209] [CLOSED] Inherit user id/group for created directories and files #539

New issue

Closed

opened 2026-02-25 23:34:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/209
Author: @rcribbs
Created: 10/28/2019
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

581f9d5 Inherit user id/group for created directories and files.

📊 Changes

2 files changed (+18 additions, -1 deletions)

View changed files

📝 internal/cmd/root.go (+6 -0)
📝 internal/core/processing.go (+12 -1)

📄 Description

I use shiori on my server in docker, but I prefer to lock down the shared mount to a user on the host server.
As it stands shiori just always creates everything under root so even if it's run under another user it doesn't play well in creating files/directories.

These changes are only in the core and in the initial data directory creation. I imagine there are some other parts of the code that could use this treatment for consistency as well, but I'm only using these portions so I only addressed these portions of the code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/209 **Author:** [@rcribbs](https://github.com/rcribbs) **Created:** 10/28/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`581f9d5`](https://github.com/go-shiori/shiori/commit/581f9d5cfa1b4b9fd4c82be67c4aacd971c70d7c) Inherit user id/group for created directories and files. ### 📊 Changes **2 files changed** (+18 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/root.go` (+6 -0) 📝 `internal/core/processing.go` (+12 -1) </details> ### 📄 Description I use shiori on my server in docker, but I prefer to lock down the shared mount to a user on the host server. As it stands shiori just always creates everything under root so even if it's run under another user it doesn't play well in creating files/directories. These changes are only in the core and in the initial data directory creation. I imagine there are some other parts of the code that could use this treatment for consistency as well, but I'm only using these portions so I only addressed these portions of the code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>