[PR #205] [MERGED] Fix: grid layout on dialog #537

New issue

Closed

opened 2026-02-25 23:34:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/205
Author: @nfam
Created: 10/14/2019
Status: ✅ Merged
Merged: 10/16/2019
Merged by: @RadhiFadlillah

Base: master ← Head: master

📝 Commits (1)

9835336 Fix: grid layout on dialog

📊 Changes

3 files changed (+66 additions, -65 deletions)

View changed files

📝 internal/view/css/custom-dialog.css (+1 -1)
📝 internal/view/less/custom-dialog.less (+1 -0)
📝 internal/webserver/assets-prod.go (+64 -64)

📄 Description

Fix #204
This happens on Add Bookmark and Tags dialogs as well.

Cause: The default value of align-content is stretch while height of .custom-dialog-body is unspecified, thus, the dialog body height will be calculated from browser viewport height.

Solution: align-content: start will help Safari able to determine the dialog body height from its children.

Tested on Safari, Firefox on macOS. Please help test on Windows.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/205 **Author:** [@nfam](https://github.com/nfam) **Created:** 10/14/2019 **Status:** ✅ Merged **Merged:** 10/16/2019 **Merged by:** [@RadhiFadlillah](https://github.com/RadhiFadlillah) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`9835336`](https://github.com/go-shiori/shiori/commit/98353369f720677906df16e2217c6a888ad55e82) Fix: grid layout on dialog ### 📊 Changes **3 files changed** (+66 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/css/custom-dialog.css` (+1 -1) 📝 `internal/view/less/custom-dialog.less` (+1 -0) 📝 `internal/webserver/assets-prod.go` (+64 -64) </details> ### 📄 Description Fix #204 This happens on Add Bookmark and Tags dialogs as well. Cause: The default value of `align-content` is `stretch` while `height` of `.custom-dialog-body` is unspecified, thus, the dialog body height will be calculated from browser viewport height. Solution: `align-content: start` will help Safari able to determine the dialog body height from its children. Tested on Safari, Firefox on macOS. Please help test on Windows. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>