[PR #187] [CLOSED] Fix custom title and excerpt not being saved when adding a new bookmark #532

New issue

Closed

opened 2026-02-25 23:34:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/187
Author: @disposedtrolley
Created: 10/2/2019
Status: ❌ Closed

Base: master ← Head: fix-insert-bookmark

📝 Commits (8)

18f551a feat: add envelope for GET /api/tags response
a23b58e feat: add envelope for GET /api/accounts response
af9e5f8 feat: update status code to 204 for DELETE operations
a715d52 feat: rename PUT /api/tag to /api/tags
d3a5133 feat: add envelope to error responses
a94fc3e feat: return 204 for PUT /api/accounts
91e1c33 chore: generate new frontend bundle
fa8f3c9 fix: store custom title and excerpt if present in the POST /api/bookmark body

📊 Changes

6 files changed (+108 additions, -81 deletions)

View changed files

📝 docs/postman/shiori.postman_collection.json (+4 -4)
📝 internal/view/js/page/home.js (+3 -3)
📝 internal/view/js/page/setting.js (+2 -2)
📝 internal/webserver/assets-prod.go (+64 -64)
📝 internal/webserver/handler-api.go (+26 -6)
📝 internal/webserver/server.go (+9 -2)

📄 Description

This PR fixes an issue where the title and excerpt attributes provided in the POST /api/bookmark request were not being saved into the database. The handler now checks whether the user has provided their own title and excerpt values, and if so, replaces the ones fetched by core.ProcessBookmark.

NB this follows on from #184 so it will need to be rebased once #184 is merged.

Thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/187 **Author:** [@disposedtrolley](https://github.com/disposedtrolley) **Created:** 10/2/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-insert-bookmark` --- ### 📝 Commits (8) - [`18f551a`](https://github.com/go-shiori/shiori/commit/18f551a65dce3ec00dd3af358d7d6f5a45aef52e) feat: add envelope for GET /api/tags response - [`a23b58e`](https://github.com/go-shiori/shiori/commit/a23b58ea77ea6fad5a1fff653b3635681aaae601) feat: add envelope for GET /api/accounts response - [`af9e5f8`](https://github.com/go-shiori/shiori/commit/af9e5f88c134a134554413ba700331438dbd1160) feat: update status code to 204 for DELETE operations - [`a715d52`](https://github.com/go-shiori/shiori/commit/a715d52391c9d68dd9d2fec48abd24e3422eda80) feat: rename PUT /api/tag to /api/tags - [`d3a5133`](https://github.com/go-shiori/shiori/commit/d3a51332a4708bb655cf72c447eee8146e3e4a9e) feat: add envelope to error responses - [`a94fc3e`](https://github.com/go-shiori/shiori/commit/a94fc3ef14e4e72c61ed5702bf3149e206410762) feat: return 204 for PUT /api/accounts - [`91e1c33`](https://github.com/go-shiori/shiori/commit/91e1c336937df82cc1919d33cbabbe2ca4fa473c) chore: generate new frontend bundle - [`fa8f3c9`](https://github.com/go-shiori/shiori/commit/fa8f3c99ff219dd6e6e58e0c9e68a06854f0132b) fix: store custom title and excerpt if present in the POST /api/bookmark body ### 📊 Changes **6 files changed** (+108 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `docs/postman/shiori.postman_collection.json` (+4 -4) 📝 `internal/view/js/page/home.js` (+3 -3) 📝 `internal/view/js/page/setting.js` (+2 -2) 📝 `internal/webserver/assets-prod.go` (+64 -64) 📝 `internal/webserver/handler-api.go` (+26 -6) 📝 `internal/webserver/server.go` (+9 -2) </details> ### 📄 Description This PR fixes an issue where the `title` and `excerpt` attributes provided in the `POST /api/bookmark` request were not being saved into the database. The handler now checks whether the user has provided their own `title` and `excerpt` values, and if so, replaces the ones fetched by `core.ProcessBookmark`. **NB** this follows on from #184 so it will need to be rebased once #184 is merged. Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>