[PR #70] [CLOSED] Improve contributor experience #510

New issue

Closed

opened 2026-02-25 23:34:33 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/70
Author: @maxmeyer
Created: 3/10/2018
Status: ❌ Closed

Base: master ← Head: feature/abstract-todo-contributors

📝 Commits (5)

d710564 Add documentation for scripts
c3eddb7 Add scripts
984f027 Use scripts in travis.yml
3a09b96 Fix readme for docker build
707b837 Use scripts in Dockerfile as well

📊 Changes

9 files changed (+86 additions, -15 deletions)

View changed files

📝 .dockerignore (+0 -1)
📝 .travis.yml (+3 -10)
📝 Dockerfile (+3 -3)
➕ Makefile (+18 -0)
📝 README.md (+35 -1)
➕ bin/build (+6 -0)
➕ bin/docker/build (+8 -0)
➕ bin/setup (+8 -0)
➕ bin/test (+5 -0)

📄 Description

Preface

This extracts some commits from #66 to focus discussion on related things.

Reason for separate PR

BTW, I think we don't really need to add those additional scripts, especially since go command is already simple enough to use. For example, setup is just wrapper for go get and build is just wrapper for go build.

Changes introduced

Add scripts
Documentation for those scripts
~~Migrate dependency handling to dep as it is stable and can handle that task well~~ This failed and was removed in a later iteration
Migrate logic from .travis.yml to scripts to make it usable for contributors as well
Replace logic in Dockerfile with scripts

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/70 **Author:** [@maxmeyer](https://github.com/maxmeyer) **Created:** 3/10/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/abstract-todo-contributors` --- ### 📝 Commits (5) - [`d710564`](https://github.com/go-shiori/shiori/commit/d710564b6cf893ab32067a52844c0abc0f538aeb) Add documentation for scripts - [`c3eddb7`](https://github.com/go-shiori/shiori/commit/c3eddb772c48f3987c9f40a37c485238f5e456d8) Add scripts - [`984f027`](https://github.com/go-shiori/shiori/commit/984f027ffc872bda97107d936077a63b3925b38e) Use scripts in travis.yml - [`3a09b96`](https://github.com/go-shiori/shiori/commit/3a09b9666abf283a6e83d48ecf7554be21e55f2d) Fix readme for docker build - [`707b837`](https://github.com/go-shiori/shiori/commit/707b8378e8176a64719364eb75890023cd96e29f) Use scripts in Dockerfile as well ### 📊 Changes **9 files changed** (+86 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `.dockerignore` (+0 -1) 📝 `.travis.yml` (+3 -10) 📝 `Dockerfile` (+3 -3) ➕ `Makefile` (+18 -0) 📝 `README.md` (+35 -1) ➕ `bin/build` (+6 -0) ➕ `bin/docker/build` (+8 -0) ➕ `bin/setup` (+8 -0) ➕ `bin/test` (+5 -0) </details> ### 📄 Description # Preface This extracts some commits from #66 to focus discussion on related things. # Reason for separate PR > BTW, I think we don't really need to add those additional scripts, especially since go command is already simple enough to use. For example, setup is just wrapper for go get and build is just wrapper for go build. # Changes introduced * Add scripts * Documentation for those scripts * ~~Migrate dependency handling to dep as it is stable and can handle that task well~~ This failed and was removed in a later iteration * Migrate logic from `.travis.yml` to scripts to make it usable for contributors as well * Replace logic in `Dockerfile` with scripts --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>