[GH-ISSUE #77] bookmarking pdf files #49

New issue

Closed

opened 2026-02-25 23:33:20 +03:00 by kerem · 1 comment

kerem commented

2026-02-25 23:33:20 +03:00

Owner

Originally created by @s-frostick on GitHub (Mar 12, 2018).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/77

If i bookmark a pdf for example http://siteresources.worldbank.org/INTRANETTRADE/Resources/C5.pdf
this causes a huge about of unreadable text to be displayed in both the extract and the cache for the bookmark.

I presume this is an issue with the go-readability library as i'm guessing it can't parse pdfs. But maybe shiori should detect the url is a pdf and not try to generate an extract or offline version.

Originally created by @s-frostick on GitHub (Mar 12, 2018). Original GitHub issue: https://github.com/go-shiori/shiori/issues/77 If i bookmark a pdf for example http://siteresources.worldbank.org/INTRANETTRADE/Resources/C5.pdf this causes a huge about of unreadable text to be displayed in both the extract and the cache for the bookmark. I presume this is an issue with the go-readability library as i'm guessing it can't parse pdfs. But maybe shiori should detect the url is a pdf and not try to generate an extract or offline version.

kerem closed this issue

2026-02-25 23:33:20 +03:00

kerem commented

2026-02-25 23:33:21 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Aug 27, 2019):

Since the ramadhan branch is merged, this issue should be fixed now. Therefore, I will close this issue. Feels free to reopen it if the issue still exists.

@RadhiFadlillah commented on GitHub (Aug 27, 2019): Since the `ramadhan` branch is merged, this issue should be fixed now. Therefore, I will close this issue. Feels free to reopen it if the issue still exists.

kerem referenced this issue

2026-02-25 23:34:32 +03:00

[PR #49] [MERGED] additions for tag cloud #504