[GH-ISSUE #1042] archive view broken when using webroot #449

Closed
opened 2026-02-25 23:34:15 +03:00 by kerem · 0 comments
Owner

Originally created by @edsu on GitHub (Dec 30, 2024).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/1042

Data

  • Shiori version: 1.7.2
  • Database Engine: SQLite
  • Operating system: linux-arm (RaspberryPi running Yunohost)
  • CLI/Web interface/Web Extension: Web Interface

Describe the bug / actual behavior

When I view an archive with an active webroot the page content doesn't render. I believe because the iframe isn't including the webroot in the source URL.

Note: I am using shiori that is installed using Yunohost. But I was able to see the same behavior when running locally on MacOS with an nginx reverse proxy.

Expected behavior

The archived page renders like it does when webroot is not being used.

To Reproduce

Steps to reproduce the behavior:

  1. run with go run main.go server --webroot shiori --port 8081
  2. configure a reverse proxy to point /shiori/ 8081 (see below)
  3. create a private (non-public) bookmark with an archive
  4. attempt to view the archive

Screenshots

Screenshot 2024-12-30 at 2 05 52 PM

Notes

Here is the nginx reverse proxy configuration I was testing with (nginx was installed with homebrew):

worker_processes  1;

events {
    worker_connections  1024;
}

http {
    include       mime.types;
    default_type  application/octet-stream;
    sendfile        on;
    keepalive_timeout  65;

    server {
        listen       8080;
        server_name  localhost;

        location / {
            root   html;
            index  index.html index.htm;
        }

        location /shiori/ {
          proxy_pass http://localhost:8081/;
        }

        error_page   500 502 503 504  /50x.html;
        location = /50x.html {
            root   html;
        }
    }

    include servers/*;
}
Originally created by @edsu on GitHub (Dec 30, 2024). Original GitHub issue: https://github.com/go-shiori/shiori/issues/1042 ## Data - **Shiori version**: 1.7.2 - **Database Engine**: SQLite - **Operating system**: linux-arm (RaspberryPi running Yunohost) - **CLI/Web interface/Web Extension**: Web Interface ## Describe the bug / actual behavior When I view an archive with an active `webroot` the page content doesn't render. I believe because the `iframe` isn't including the `webroot` in the source URL. Note: I am using shiori that is installed using [Yunohost](https://github.com/YunoHost-Apps/shiori_ynh). But I was able to see the same behavior when running locally on MacOS with an nginx reverse proxy. ## Expected behavior The archived page renders like it does when `webroot` is not being used. ## To Reproduce Steps to reproduce the behavior: 1. run with `go run main.go server --webroot shiori --port 8081` 1. configure a reverse proxy to point `/shiori/` 8081 (see below) 1. create a private (non-public) bookmark with an archive 1. attempt to view the archive ## Screenshots ![Screenshot 2024-12-30 at 2 05 52 PM](https://github.com/user-attachments/assets/521d514a-d660-42c5-99f3-85d7281fc38a) ## Notes Here is the nginx reverse proxy configuration I was testing with (nginx was installed with homebrew): ```nginx worker_processes 1; events { worker_connections 1024; } http { include mime.types; default_type application/octet-stream; sendfile on; keepalive_timeout 65; server { listen 8080; server_name localhost; location / { root html; index index.html index.htm; } location /shiori/ { proxy_pass http://localhost:8081/; } error_page 500 502 503 504 /50x.html; location = /50x.html { root html; } } include servers/*; } ```
kerem 2026-02-25 23:34:15 +03:00
  • closed this issue
  • added the
    type:bug
    label
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#449
No description provided.