mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 06:25:54 +03:00
[GH-ISSUE #994] Manual upload of cover picture #435
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#435
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @imclint21 on GitHub (Oct 12, 2024).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/994
Hi,
For some bookmarks I would be able to upload a custom image when the automatic fetching does not works.
Regards
@mayur1377 commented on GitHub (Oct 12, 2024):
hey @imclint21 , I can give this a try :)
@imclint21 commented on GitHub (Oct 12, 2024):
would be awesome!
@mayur1377 commented on GitHub (Oct 12, 2024):
the way the images are stored is quite inconsistent , make it difficult to work with :)
made a workaround for have a "random" placeholder if it was unable to fetch images from the provided URL ,
lemme know if I can go ahead and raise a PR :)
@imclint21 commented on GitHub (Oct 12, 2024):
I would recommend to use https://place-hold.it/ or something neutral for default image,
Also i'm not maintainer of this project :D
@mayur1377 commented on GitHub (Oct 13, 2024):
@fmartingr , lemme know what to do :D
@fmartingr commented on GitHub (Oct 14, 2024):
Unsure what the ask is here. It is uploading thumbnails or it is having placeholders for bookmarks without thumbnails? (I'm against placeholders)
@imclint21 As a workaround, you can put an image into the
$SHIORI_DIR/thumbfolder named after the ID of the bookmark. That is, if you upload an image file named44in that folder it should show up as thumbnail. This may change recently if we normalize data in the database but should work as of today.@imclint21 commented on GitHub (Oct 14, 2024):
You can edit all the metadata of any bookmark why not let the possibility to upload a custom thumb like I can edit the title?
I'm sure @mayur1377 can handle it quickly, just need to upload the new image in
$SHIORI_DIR/thumbas you said.@imclint21 commented on GitHub (Oct 30, 2024):
Any news on this @fmartingr @mayur1377? :D
I like Shiori but it looks bad without thumbs haha
@morley461 commented on GitHub (Dec 20, 2024):
That would be awesome. It's the only thing that's missing for me.
@imclint21 commented on GitHub (Dec 20, 2024):
I agree and it will give more consistence, all can be edited excepting cover, while automatic cover downloader can don't do his job.
@imclint21 commented on GitHub (Dec 28, 2024):
Any news on this @fmartingr?
@fmartingr commented on GitHub (Jan 1, 2025):
This is a low priority for me at the moment, more so considering that the workaround of putting the files manually in the data directory can be used.