[GH-ISSUE #994] Manual upload of cover picture #435

Open
opened 2026-02-25 23:34:13 +03:00 by kerem · 12 comments
Owner

Originally created by @imclint21 on GitHub (Oct 12, 2024).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/994

Hi,

For some bookmarks I would be able to upload a custom image when the automatic fetching does not works.

Regards

Originally created by @imclint21 on GitHub (Oct 12, 2024). Original GitHub issue: https://github.com/go-shiori/shiori/issues/994 Hi, For some bookmarks I would be able to upload a custom image when the automatic fetching does not works. Regards
Author
Owner

@mayur1377 commented on GitHub (Oct 12, 2024):

hey @imclint21 , I can give this a try :)

<!-- gh-comment-id:2408601180 --> @mayur1377 commented on GitHub (Oct 12, 2024): hey @imclint21 , I can give this a try :)
Author
Owner

@imclint21 commented on GitHub (Oct 12, 2024):

would be awesome!

<!-- gh-comment-id:2408601383 --> @imclint21 commented on GitHub (Oct 12, 2024): would be awesome!
Author
Owner

@mayur1377 commented on GitHub (Oct 12, 2024):

the way the images are stored is quite inconsistent , make it difficult to work with :)
made a workaround for have a "random" placeholder if it was unable to fetch images from the provided URL ,
lemme know if I can go ahead and raise a PR :)

<!-- gh-comment-id:2408624747 --> @mayur1377 commented on GitHub (Oct 12, 2024): the way the images are stored is quite inconsistent , make it difficult to work with :) made a [workaround](https://github.com/go-shiori/shiori/compare/master...mayur1377:shiori:feature/image?expand=1) for have a "random" placeholder if it was unable to fetch images from the provided URL , lemme know if I can go ahead and raise a PR :)
Author
Owner

@imclint21 commented on GitHub (Oct 12, 2024):

I would recommend to use https://place-hold.it/ or something neutral for default image,

Also i'm not maintainer of this project :D

<!-- gh-comment-id:2408630185 --> @imclint21 commented on GitHub (Oct 12, 2024): I would recommend to use https://place-hold.it/ or something neutral for default image, Also i'm not maintainer of this project :D
Author
Owner

@mayur1377 commented on GitHub (Oct 13, 2024):

@fmartingr , lemme know what to do :D

<!-- gh-comment-id:2408848074 --> @mayur1377 commented on GitHub (Oct 13, 2024): @fmartingr , lemme know what to do :D
Author
Owner

@fmartingr commented on GitHub (Oct 14, 2024):

Unsure what the ask is here. It is uploading thumbnails or it is having placeholders for bookmarks without thumbnails? (I'm against placeholders)

@imclint21 As a workaround, you can put an image into the $SHIORI_DIR/thumb folder named after the ID of the bookmark. That is, if you upload an image file named 44 in that folder it should show up as thumbnail. This may change recently if we normalize data in the database but should work as of today.

<!-- gh-comment-id:2411814730 --> @fmartingr commented on GitHub (Oct 14, 2024): Unsure what the ask is here. It is uploading thumbnails or it is having placeholders for bookmarks without thumbnails? (I'm against placeholders) @imclint21 As a workaround, you can put an image into the `$SHIORI_DIR/thumb` folder named after the ID of the bookmark. That is, if you upload an image file named `44` in that folder it should show up as thumbnail. This may change recently if we normalize data in the database but should work as of today.
Author
Owner

@imclint21 commented on GitHub (Oct 14, 2024):

You can edit all the metadata of any bookmark why not let the possibility to upload a custom thumb like I can edit the title?

I'm sure @mayur1377 can handle it quickly, just need to upload the new image in $SHIORI_DIR/thumb as you said.

<!-- gh-comment-id:2411832159 --> @imclint21 commented on GitHub (Oct 14, 2024): You can edit all the metadata of any bookmark why not let the possibility to upload a custom thumb like I can edit the title? I'm sure @mayur1377 can handle it quickly, just need to upload the new image in `$SHIORI_DIR/thumb` as you said.
Author
Owner

@imclint21 commented on GitHub (Oct 30, 2024):

Any news on this @fmartingr @mayur1377? :D

I like Shiori but it looks bad without thumbs haha

image
<!-- gh-comment-id:2447968433 --> @imclint21 commented on GitHub (Oct 30, 2024): Any news on this @fmartingr @mayur1377? :D I like Shiori but it looks bad without thumbs haha <img width="1476" alt="image" src="https://github.com/user-attachments/assets/27571560-a188-4f01-9d72-c4b2fae27296">
Author
Owner

@morley461 commented on GitHub (Dec 20, 2024):

That would be awesome. It's the only thing that's missing for me.

<!-- gh-comment-id:2557538844 --> @morley461 commented on GitHub (Dec 20, 2024): That would be awesome. It's the only thing that's missing for me.
Author
Owner

@imclint21 commented on GitHub (Dec 20, 2024):

I agree and it will give more consistence, all can be edited excepting cover, while automatic cover downloader can don't do his job.

<!-- gh-comment-id:2557586847 --> @imclint21 commented on GitHub (Dec 20, 2024): I agree and it will give more consistence, all can be edited excepting cover, while automatic cover downloader can don't do his job.
Author
Owner

@imclint21 commented on GitHub (Dec 28, 2024):

Any news on this @fmartingr?

<!-- gh-comment-id:2564304961 --> @imclint21 commented on GitHub (Dec 28, 2024): Any news on this @fmartingr?
Author
Owner

@fmartingr commented on GitHub (Jan 1, 2025):

This is a low priority for me at the moment, more so considering that the workaround of putting the files manually in the data directory can be used.

<!-- gh-comment-id:2567067152 --> @fmartingr commented on GitHub (Jan 1, 2025): This is a low priority for me at the moment, more so considering that the workaround of putting the files manually in the data directory can be used.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#435
No description provided.