[GH-ISSUE #857] Issue with image display in Chrome v1.6.0-rc.7 #397

Closed
opened 2026-02-25 23:34:08 +03:00 by kerem · 2 comments
Owner

Originally created by @DesarrolloAntonio on GitHub (Mar 12, 2024).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/857

Originally assigned to: @Monirzadeh on GitHub.

Problem Description

I am experiencing an issue with the display of images in the Shiori app when using Google Chrome. I'm currently testing with version v1.6.0-rc.7 of Shiori.

Steps to Reproduce

  1. Create several bookmarks in the app.
  2. Delete all the created bookmarks.
  3. Add several bookmarks again.
  4. Open the app in an incognito tab on the left and a normal tab on the right (See capture)
  5. Observe that on the right tab, only one image is displayed correctly.

Captura de pantalla_área-de-selección_20240312164127

Edit: I've also noticed that this issue occasionally occurs in incognito mode as well.

image

Originally created by @DesarrolloAntonio on GitHub (Mar 12, 2024). Original GitHub issue: https://github.com/go-shiori/shiori/issues/857 Originally assigned to: @Monirzadeh on GitHub. ### Problem Description I am experiencing an issue with the display of images in the Shiori app when using Google Chrome. I'm currently testing with version v1.6.0-rc.7 of Shiori. ### Steps to Reproduce 1. Create several bookmarks in the app. 2. Delete all the created bookmarks. 3. Add several bookmarks again. 4. Open the app in an incognito tab on the left and a normal tab on the right (See capture) 5. Observe that on the right tab, only one image is displayed correctly. ![Captura de pantalla_área-de-selección_20240312164127](https://github.com/go-shiori/shiori/assets/7002198/4ac8e3e4-ae38-4e20-901d-687121135060) Edit: I've also noticed that this issue occasionally occurs in incognito mode as well. ![image](https://github.com/go-shiori/shiori/assets/7002198/5f4150a3-9c6d-4945-ab43-6470cd28b449)
kerem 2026-02-25 23:34:08 +03:00
  • closed this issue
  • added the
    type:bug
    label
Author
Owner

@Monirzadeh commented on GitHub (Mar 14, 2024):

hi i test that it happen just when i use refresh in shiori and if i use ctrl + F5 it fix.
somehow refresh can't clean cache of browser but i don't find why it happen for some of bookmark yet
@fmartingr do you have any idea?

update: i test that in firefox.

update:
change this part
github.com/go-shiori/shiori@595cb45a2c/internal/view/assets/js/component/bookmark.js (L96-L100)
to somthing like this solve problem in my tests

thumbnailStyleURL() {
    const cacheBuster = new Date().getTime(); // Unique timestamp
    const thumbnailWithCacheBuster = `${this.imageURL}?cache=${cacheBuster}`;
    return {
        backgroundImage: `url("${thumbnailWithCacheBuster}")`,
    };
},

what do you think? any better solution?
if it is fine to you send i will send a PR to fix that.

@DesarrolloAntonio can you test this on your system and report if problem will solve with this change for you too?

<!-- gh-comment-id:1998290805 --> @Monirzadeh commented on GitHub (Mar 14, 2024): hi i test that it happen just when i use refresh in shiori and if i use ctrl + F5 it fix. somehow refresh can't clean cache of browser but i don't find why it happen for some of bookmark yet @fmartingr do you have any idea? update: i test that in firefox. update: change this part https://github.com/go-shiori/shiori/blob/595cb45a2ce7031926ead1f1e1324e673e36d676/internal/view/assets/js/component/bookmark.js#L96-L100 to somthing like this solve problem in my tests ``` thumbnailStyleURL() { const cacheBuster = new Date().getTime(); // Unique timestamp const thumbnailWithCacheBuster = `${this.imageURL}?cache=${cacheBuster}`; return { backgroundImage: `url("${thumbnailWithCacheBuster}")`, }; }, ``` what do you think? any better solution? if it is fine to you send i will send a PR to fix that. @DesarrolloAntonio can you test this on your system and report if problem will solve with this change for you too?
Author
Owner

@DesarrolloAntonio commented on GitHub (Mar 15, 2024):

hi i test that it happen just when i use refresh in shiori and if i use ctrl + F5 it fix. somehow refresh can't clean cache of browser but i don't find why it happen for some of bookmark yet @fmartingr do you have any idea?

update: i test that in firefox.

update: change this part

github.com/go-shiori/shiori@595cb45a2c/internal/view/assets/js/component/bookmark.js (L96-L100)

to somthing like this solve problem in my tests

thumbnailStyleURL() {
    const cacheBuster = new Date().getTime(); // Unique timestamp
    const thumbnailWithCacheBuster = `${this.imageURL}?cache=${cacheBuster}`;
    return {
        backgroundImage: `url("${thumbnailWithCacheBuster}")`,
    };
},

what do you think? any better solution? if it is fine to you send i will send a PR to fix that.

@DesarrolloAntonio can you test this on your system and report if problem will solve with this change for you too?

In the Android app PageKeeper, I fixed it with a similar solution, but instead of a timestamp, I added the "modified" field.

// Append 'lastUpdated' query to image URL for cache busting. Forces retrieval of updated images.
val imageUrl = "${serverURL.removeTrailingSlash()}${bookmark.imageURL}?lastUpdated=${bookmark.modified}"
<!-- gh-comment-id:1999053864 --> @DesarrolloAntonio commented on GitHub (Mar 15, 2024): > hi i test that it happen just when i use refresh in shiori and if i use ctrl + F5 it fix. somehow refresh can't clean cache of browser but i don't find why it happen for some of bookmark yet @fmartingr do you have any idea? > > update: i test that in firefox. > > update: change this part > > https://github.com/go-shiori/shiori/blob/595cb45a2ce7031926ead1f1e1324e673e36d676/internal/view/assets/js/component/bookmark.js#L96-L100 > > > to somthing like this solve problem in my tests > ``` > thumbnailStyleURL() { > const cacheBuster = new Date().getTime(); // Unique timestamp > const thumbnailWithCacheBuster = `${this.imageURL}?cache=${cacheBuster}`; > return { > backgroundImage: `url("${thumbnailWithCacheBuster}")`, > }; > }, > ``` > > what do you think? any better solution? if it is fine to you send i will send a PR to fix that. > > @DesarrolloAntonio can you test this on your system and report if problem will solve with this change for you too? In the Android app PageKeeper, I fixed it with a similar solution, but instead of a timestamp, I added the "modified" field. ``` // Append 'lastUpdated' query to image URL for cache busting. Forces retrieval of updated images. val imageUrl = "${serverURL.removeTrailingSlash()}${bookmark.imageURL}?lastUpdated=${bookmark.modified}" ```
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#397
No description provided.