mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #857] Issue with image display in Chrome v1.6.0-rc.7 #397
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#397
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DesarrolloAntonio on GitHub (Mar 12, 2024).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/857
Originally assigned to: @Monirzadeh on GitHub.
Problem Description
I am experiencing an issue with the display of images in the Shiori app when using Google Chrome. I'm currently testing with version v1.6.0-rc.7 of Shiori.
Steps to Reproduce
Edit: I've also noticed that this issue occasionally occurs in incognito mode as well.
@Monirzadeh commented on GitHub (Mar 14, 2024):
hi i test that it happen just when i use refresh in shiori and if i use ctrl + F5 it fix.
somehow refresh can't clean cache of browser but i don't find why it happen for some of bookmark yet
@fmartingr do you have any idea?
update: i test that in firefox.
update:
change this part
github.com/go-shiori/shiori@595cb45a2c/internal/view/assets/js/component/bookmark.js (L96-L100)to somthing like this solve problem in my tests
what do you think? any better solution?
if it is fine to you send i will send a PR to fix that.
@DesarrolloAntonio can you test this on your system and report if problem will solve with this change for you too?
@DesarrolloAntonio commented on GitHub (Mar 15, 2024):
In the Android app PageKeeper, I fixed it with a similar solution, but instead of a timestamp, I added the "modified" field.