[GH-ISSUE #838] shiori print command or API doesn't return the thumbnail url #393

Open
opened 2026-02-25 23:34:07 +03:00 by kerem · 1 comment
Owner

Originally created by @brunoamaral on GitHub (Feb 7, 2024).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/838

Data

  • Shiori version: v1.6.0-rc.7
  • Database Engine: sqlite
  • Operating system: ubuntu
  • CLI/Web interface/Web Extension: CLI

Describe the bug / actual behavior

Maybe this is actually the expected behaviour, but running shiori print -j doesn't show a value for imageURL. It only returns ID, url, title, excerpt, public, modified, hasContent, tags, hasArchive, hasEbook, create_archive, and create_ebook.

Expected behavior

Any value for the imageUrl.

To Reproduce

shiori print -j or visit api/v1/bookmarks/

Screenshots

Notes

Originally created by @brunoamaral on GitHub (Feb 7, 2024). Original GitHub issue: https://github.com/go-shiori/shiori/issues/838 ## Data - **Shiori version**: v1.6.0-rc.7 - **Database Engine**: sqlite - **Operating system**: ubuntu - **CLI/Web interface/Web Extension**: CLI ## Describe the bug / actual behavior Maybe this is actually the expected behaviour, but running `shiori print -j` doesn't show a value for imageURL. It only returns ID, url, title, excerpt, public, modified, hasContent, tags, hasArchive, hasEbook, create_archive, and create_ebook. ## Expected behavior Any value for the imageUrl. ## To Reproduce `shiori print -j` or visit `api/v1/bookmarks/` ## Screenshots ## Notes
Author
Owner

@fmartingr commented on GitHub (May 18, 2024):

Investigation note: I checked this briefly today and the problem is that the old API filled the DTO model with all required field. We need to move this logic into the BookmarksDomain and use that from the API and the CLI.

<!-- gh-comment-id:2118673249 --> @fmartingr commented on GitHub (May 18, 2024): Investigation note: I checked this briefly today and the problem is that the old API filled the DTO model with all required field. We need to move this logic into the `BookmarksDomain` and use that from the API and the CLI.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#393
No description provided.