mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #838] shiori print command or API doesn't return the thumbnail url #393
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#393
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @brunoamaral on GitHub (Feb 7, 2024).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/838
Data
Describe the bug / actual behavior
Maybe this is actually the expected behaviour, but running
shiori print -jdoesn't show a value for imageURL. It only returns ID, url, title, excerpt, public, modified, hasContent, tags, hasArchive, hasEbook, create_archive, and create_ebook.Expected behavior
Any value for the imageUrl.
To Reproduce
shiori print -jor visitapi/v1/bookmarks/Screenshots
Notes
@fmartingr commented on GitHub (May 18, 2024):
Investigation note: I checked this briefly today and the problem is that the old API filled the DTO model with all required field. We need to move this logic into the
BookmarksDomainand use that from the API and the CLI.