mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #820] Route /api/login not available #389
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#389
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pettersillander on GitHub (Jan 23, 2024).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/820
Data
Describe the bug / actual behavior
It seems there's no route for /api/login currently.
Expected behavior
Http client should be able use /api/login to authenticate session
To Reproduce
curl http://example.com/api/login -d {"login details"} -> 404
Notes
This (/api/login) route is in API.md. But for api auth one would still need to use only api/v1/auth/login endpoint it seems.
Maybe there should be a notice in the api docs or is this going to change soon?
@Monirzadeh commented on GitHub (Jan 23, 2024):
we move to api/v1/auth/login and for new api i suggest review this https://github.com/go-shiori/shiori/blob/master/docs/APIv1.md for login and we remove that for v1.6
we plan that to update documentation here in #663
if you think it should not close please mention here.
@pettersillander commented on GitHub (Jan 23, 2024):
Sorry, I mixed old and new api. v1 is the new one, not other way round. Thanks, all good then.
@wbste commented on GitHub (Feb 18, 2024):
I'm getting the opposite error and different issue.
http://desktop.lan/api/v1/auth/logindoesn't exist but the older API does. When I call it I get a 200, but the expiration date is when it's sent. Therefore I can never get a valid session id. Running the windows x64 binary from here: shiori_Windows_x86_64.tar.gz. Any thoughts? Is there a way I can just use the CLI to change the master password?Running server with
.\shiori.exe serve --portable@Monirzadeh commented on GitHub (Feb 18, 2024):
Which version?
please add command that use to run server?
@wbste commented on GitHub (Feb 18, 2024):
Version of...? I gave a link to the release I'm using above if that's what you were looking for.
EDIT: I don't even see the default account in the sqlite dB...just the read only account I created. Is there some other place to change it?
@Monirzadeh commented on GitHub (Feb 18, 2024):
I don't acsses to my system right now.
Can you please run shiori with
serverinstead ofserveAbout the user as I remmmber we change the way default user work and not have that in database anymore.
@wbste commented on GitHub (Feb 18, 2024):
I want to basically disable that default username and password, so let me know how to do that. Either delete that account, change the password, or...
@Monirzadeh commented on GitHub (Feb 19, 2024):
OK i finally test that my self
new API activate for login in v1.6 not v1.5.5.
about default user. when you login with default user name (shiori) and password (gopher) go to the settings and add new account as owner (default username and password will disable automatically after your create first real account in settings)
change password and other things available in settings too.