mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 06:25:54 +03:00
[GH-ISSUE #788] Start page bug #380
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#380
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @LLKoder on GitHub (Nov 27, 2023).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/788
Data
Describe the bug / actual behavior
When I first open browser with Shiori I see error:
Error - Session has expired, please login again....instead login page.
If I click 'OK' it relocate me to login page, but why do I get error when I first open browser without any cookies?
@Monirzadeh commented on GitHub (Nov 27, 2023):
it show error because it can't find cookies that needed.
@fmartingr can we redirect without show error or automatically redirect after 3 second (or at least if user open root?)
currently it is a little confusing.
@LLKoder commented on GitHub (Nov 27, 2023):
Yep, I said about this. Why show this error if users open this page first times. I understand if it show me in second, .. etc, but first times. I have not been even login Shiori at all.
@fmartingr commented on GitHub (Dec 9, 2023):
This happens because the error logic in the frontend is centralised in a single place, that means that for any error that the API returns we show the error dialog. I agree that the best UX here would be to redirect to login directly, and if the user tried to access a page directly show a "You are not logged in, please authenticate" message in the login page. After login in, the user will get redirected to the page that was trying to open.