[GH-ISSUE #788] Start page bug #380

Open
opened 2026-02-25 23:34:05 +03:00 by kerem · 3 comments
Owner

Originally created by @LLKoder on GitHub (Nov 27, 2023).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/788

Data

  • Shiori version: lastest
  • Database Engine: sqlite
  • Operating system: linux
  • CLI/Web interface/Web Extension: Web interface

Describe the bug / actual behavior

When I first open browser with Shiori I see error:

Error - Session has expired, please login again.

...instead login page.

If I click 'OK' it relocate me to login page, but why do I get error when I first open browser without any cookies?

2023-11-27_15-35

Originally created by @LLKoder on GitHub (Nov 27, 2023). Original GitHub issue: https://github.com/go-shiori/shiori/issues/788 ## Data - **Shiori version**: lastest - **Database Engine**: sqlite - **Operating system**: linux - **CLI/Web interface/Web Extension**: Web interface ## Describe the bug / actual behavior When I first open browser with Shiori I see error: `Error - Session has expired, please login again.` ...instead login page. If I click 'OK' it relocate me to login page, but why do I get error when I first open browser without any cookies? ![2023-11-27_15-35](https://github.com/go-shiori/shiori/assets/50442676/1370b956-974d-4c43-a8f8-bafe33261b8d)
Author
Owner

@Monirzadeh commented on GitHub (Nov 27, 2023):

it show error because it can't find cookies that needed.
@fmartingr can we redirect without show error or automatically redirect after 3 second (or at least if user open root?)
currently it is a little confusing.

<!-- gh-comment-id:1827502806 --> @Monirzadeh commented on GitHub (Nov 27, 2023): it show error because it can't find cookies that needed. @fmartingr can we redirect without show error or automatically redirect after 3 second (or at least if user open root?) currently it is a little confusing.
Author
Owner

@LLKoder commented on GitHub (Nov 27, 2023):

it show error because it can't find cookies that needed.

Yep, I said about this. Why show this error if users open this page first times. I understand if it show me in second, .. etc, but first times. I have not been even login Shiori at all.

<!-- gh-comment-id:1828034764 --> @LLKoder commented on GitHub (Nov 27, 2023): > it show error because it can't find cookies that needed. Yep, I said about this. Why show this error if users open this page first times. I understand if it show me in second, .. etc, but first times. I have not been even login Shiori at all.
Author
Owner

@fmartingr commented on GitHub (Dec 9, 2023):

This happens because the error logic in the frontend is centralised in a single place, that means that for any error that the API returns we show the error dialog. I agree that the best UX here would be to redirect to login directly, and if the user tried to access a page directly show a "You are not logged in, please authenticate" message in the login page. After login in, the user will get redirected to the page that was trying to open.

<!-- gh-comment-id:1848319409 --> @fmartingr commented on GitHub (Dec 9, 2023): This happens because the error logic in the frontend is centralised in a single place, that means that for **any** error that the API returns we show the error dialog. I agree that the best UX here would be to redirect to login directly, and if the user tried to access a page directly show a "You are not logged in, please authenticate" message in the login page. After login in, the user will get redirected to the page that was trying to open.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#380
No description provided.