starred/shiori
1
0
Fork 0
mirror of https://github.com/go-shiori/shiori.git synced 2026-04-25 06:25:54 +03:00
Code Issues 103 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #773] empty epub #372

New issue
Open
opened 2026-02-25 23:34:04 +03:00 by kerem · 6 comments
kerem commented 2026-02-25 23:34:04 +03:00
Owner
Copy link

Originally created by @pocelka on GitHub (Nov 2, 2023).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/773

Data

  • Shiori version: 1.5.5
  • Database Engine: SQL Lite3
  • Operating system: Docker container (host OS: Fedora 38)
  • CLI/Web interface/Web Extension: Beta Extension 1.1

Describe the bug / actual behavior

When I download article as an ebook, downloaded file is empty.

Expected behavior

eBook is created with size greater then 0 bytes.

To Reproduce

Steps to reproduce the behavior:
0. Save link: https://blogs.oracle.com/cloud-infrastructure/post/adv-terraform-stack-logic-oracle-resource-manager

  1. Go to "top menu" -> batch edit
  2. Click on "saved article"
  3. Click on "top menu" -> download ebooks

Screenshots

image

EDIT:
Seems like it also creates a copy of ebook in the mounted docker volume. Not sure if that is correct since it downloaded also file to my host machine:
image

Originally created by @pocelka on GitHub (Nov 2, 2023). Original GitHub issue: https://github.com/go-shiori/shiori/issues/773 ## Data - **Shiori version**: 1.5.5 - **Database Engine**: SQL Lite3 - **Operating system**: Docker container (host OS: Fedora 38) - **CLI/Web interface/Web Extension**: Beta Extension 1.1 ## Describe the bug / actual behavior When I download article as an ebook, downloaded file is empty. ## Expected behavior eBook is created with size greater then 0 bytes. ## To Reproduce Steps to reproduce the behavior: 0. Save link: https://blogs.oracle.com/cloud-infrastructure/post/adv-terraform-stack-logic-oracle-resource-manager 1. Go to "top menu" -> batch edit 2. Click on "saved article" 3. Click on "top menu" -> download ebooks ## Screenshots ![image](https://github.com/go-shiori/shiori/assets/20441822/0c6aeaf3-395f-4677-9335-f80d976536a5) **EDIT:** Seems like it also creates a copy of ebook in the mounted docker volume. Not sure if that is correct since it downloaded also file to my host machine: ![image](https://github.com/go-shiori/shiori/assets/20441822/2e538acf-b4e9-4825-98d2-7e61cfb8d3bb)
kerem commented 2026-02-25 23:34:04 +03:00
Author
Owner
Copy link

@pocelka commented on GitHub (Nov 2, 2023):

I did one more try and I removed the epub file from the docker mounted volume. Then during the epub donwload I'm getting:
image

So maybe it is related to the reported issue. Because I have seen the error also the first time, but 2nd time when I tried to download ebook it went fine, it just created empty file.

In docker logs I have this:

time="2023-11-02T19:17:04+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=test" proto=HTTP/1.1 remote="192.168.1.2:34734" reqlen=0 size=38 status=200
time="2023-11-02T19:17:05+01:00" level=info msg="POST /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:34734" reqlen=211 size=378 status=200
time="2023-11-02T19:17:12+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=test" proto=HTTP/1.1 remote="192.168.1.2:34734" reqlen=0 size=38 status=200
2023/11/02 19:17:13 error during commit: sql: transaction has already been committed or rolled back
time="2023-11-02T19:17:13+01:00" level=warning msg="POST /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:34734" reqlen=211 size=90 status=500
time="2023-11-02T19:17:20+01:00" level=info msg="GET /" proto=HTTP/1.1 remote="192.168.1.2:48562" reqlen=0 size=5659 status=200
time="2023-11-02T19:17:20+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:48562" reqlen=0 size=430 status=200
time="2023-11-02T19:17:20+01:00" level=info msg="GET /api/tags" proto=HTTP/1.1 remote="192.168.1.2:48562" reqlen=0 size=3 status=200
time="2023-11-02T19:17:31+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:51206" reqlen=0 size=23251 status=200
time="2023-11-02T19:17:34+01:00" level=info msg="GET /api/accounts" proto=HTTP/1.1 remote="192.168.1.2:51206" reqlen=0 size=50 status=200
time="2023-11-02T19:17:55+01:00" level=info msg="DELETE /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=3 size=1 status=200
time="2023-11-02T19:17:55+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=38 status=200
time="2023-11-02T19:17:56+01:00" level=info msg="GET /" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=5659 status=200
time="2023-11-02T19:17:56+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=38 status=200
time="2023-11-02T19:17:56+01:00" level=info msg="GET /api/tags" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=3 status=200
time="2023-11-02T19:17:59+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=test" proto=HTTP/1.1 remote="192.168.1.2:50884" reqlen=0 size=38 status=200
time="2023-11-02T19:18:00+01:00" level=info msg="POST /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:50884" reqlen=211 size=378 status=200
time="2023-11-02T19:18:02+01:00" level=info msg="GET /" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=5659 status=200
time="2023-11-02T19:18:02+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=430 status=200
time="2023-11-02T19:18:02+01:00" level=info msg="GET /api/tags" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=3 status=200
time="2023-11-02T19:18:03+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=23251 status=200
time="2023-11-02T19:19:17+01:00" level=info msg="PUT /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:60706" reqlen=427 size=24402 status=200
time="2023-11-02T19:19:24+01:00" level=info msg="GET /api/bookmarks?keyword=terra&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:60706" reqlen=0 size=479 status=200
time="2023-11-02T19:19:28+01:00" level=info msg="GET /api/accounts" proto=HTTP/1.1 remote="192.168.1.2:60706" reqlen=0 size=50 status=200
time="2023-11-02T19:19:31+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:60706" reqlen=0 size=23251 status=200
2023/11/02 19:20:15 Get "https://blogs.oracle.com/content/published/api/v1.1/assets/CONTCEBA0B3AED4240679C38D845E54FB5DF/Medium?cb=_cache_506c&channelToken=f7814d202b7d468686f50574164024ec&format=jpg": stream error: stream ID 3; INTERNAL_ERROR; received from peer
time="2023-11-02T19:20:15+01:00" level=info msg="Serve shiori in :8080 /"
time="2023-11-02T19:20:37+01:00" level=warning msg="PUT /api/ebook" proto=HTTP/1.1 remote="192.168.1.2:42482" reqlen=11 size=25 status=500
time="2023-11-02T19:20:39+01:00" level=info msg="GET /login?dst=http%3A%2F%2F192.168.1.3%3A9009%2F%3Fsearch%3Dterra%23home" proto=HTTP/1.1 remote="192.168.1.2:42482" reqlen=0 size=4299 status=200
time="2023-11-02T19:20:49+01:00" level=warning msg="GET /" proto=HTTP/1.1 remote="192.168.1.2:33532" reqlen=0 size=49 status=301
time="2023-11-02T19:20:49+01:00" level=info msg="GET /login?dst=%2F" proto=HTTP/1.1 remote="192.168.1.2:33532" reqlen=0 size=4299 status=200
time="2023-11-02T19:21:14+01:00" level=info msg="POST /api/login" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=83 size=151 status=200
time="2023-11-02T19:21:14+01:00" level=info msg="GET /" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=0 size=5659 status=200
time="2023-11-02T19:21:15+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=0 size=478 status=200
time="2023-11-02T19:21:15+01:00" level=info msg="GET /api/tags" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=0 size=85 status=200
time="2023-11-02T19:21:21+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=0 size=23382 status=200
time="2023-11-02T19:21:31+01:00" level=info msg="PUT /api/ebook" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=11 size=24403 status=200
time="2023-11-02T19:21:31+01:00" level=warning msg="GET /bookmark/1/ebook" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=0 size=0 status=0
time="2023-11-02T19:22:00+01:00" level=info msg="GET /api/accounts" proto=HTTP/1.1 remote="192.168.1.2:43878" reqlen=0 size=50 status=200
time="2023-11-02T19:23:01+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:38182" reqlen=0 size=478 status=200
time="2023-11-02T19:23:01+01:00" level=info msg="GET /api/tags" proto=HTTP/1.1 remote="192.168.1.2:38182" reqlen=0 size=85 status=200
time="2023-11-02T19:23:32+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:59754" reqlen=0 size=23382 status=200
time="2023-11-02T19:24:41+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=test" proto=HTTP/1.1 remote="192.168.1.2:41388" reqlen=0 size=38 status=200
time="2023-11-02T19:25:55+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:55438" reqlen=0 size=23382 status=200
time="2023-11-02T19:26:20+01:00" level=info msg="PUT /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:49298" reqlen=423 size=24399 status=200
time="2023-11-02T19:28:16+01:00" level=info msg="PUT /api/ebook" proto=HTTP/1.1 remote="192.168.1.2:60124" reqlen=11 size=24400 status=200
time="2023-11-02T19:28:16+01:00" level=warning msg="GET /bookmark/1/ebook" proto=HTTP/1.1 remote="192.168.1.2:60124" reqlen=0 size=0 status=0
2023/11/02 19:35:21 Get "https://blogs.oracle.com/content/published/api/v1.1/assets/CONTCEBA0B3AED4240679C38D845E54FB5DF/Medium?cb=_cache_506c&channelToken=f7814d202b7d468686f50574164024ec&format=jpg": stream error: stream ID 3; INTERNAL_ERROR; received from peer
time="2023-11-02T19:35:21+01:00" level=info msg="Serve shiori in :8080 /"
<!-- gh-comment-id:1791324516 --> @pocelka commented on GitHub (Nov 2, 2023): I did one more try and I removed the epub file from the docker mounted volume. Then during the epub donwload I'm getting: ![image](https://github.com/go-shiori/shiori/assets/20441822/494d7313-dead-4e01-9bf1-6214c693a456) So maybe it is related to the reported issue. Because I have seen the error also the first time, but 2nd time when I tried to download ebook it went fine, it just created empty file. In docker logs I have this: ``` time="2023-11-02T19:17:04+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=test" proto=HTTP/1.1 remote="192.168.1.2:34734" reqlen=0 size=38 status=200 time="2023-11-02T19:17:05+01:00" level=info msg="POST /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:34734" reqlen=211 size=378 status=200 time="2023-11-02T19:17:12+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=test" proto=HTTP/1.1 remote="192.168.1.2:34734" reqlen=0 size=38 status=200 2023/11/02 19:17:13 error during commit: sql: transaction has already been committed or rolled back time="2023-11-02T19:17:13+01:00" level=warning msg="POST /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:34734" reqlen=211 size=90 status=500 time="2023-11-02T19:17:20+01:00" level=info msg="GET /" proto=HTTP/1.1 remote="192.168.1.2:48562" reqlen=0 size=5659 status=200 time="2023-11-02T19:17:20+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:48562" reqlen=0 size=430 status=200 time="2023-11-02T19:17:20+01:00" level=info msg="GET /api/tags" proto=HTTP/1.1 remote="192.168.1.2:48562" reqlen=0 size=3 status=200 time="2023-11-02T19:17:31+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:51206" reqlen=0 size=23251 status=200 time="2023-11-02T19:17:34+01:00" level=info msg="GET /api/accounts" proto=HTTP/1.1 remote="192.168.1.2:51206" reqlen=0 size=50 status=200 time="2023-11-02T19:17:55+01:00" level=info msg="DELETE /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=3 size=1 status=200 time="2023-11-02T19:17:55+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=38 status=200 time="2023-11-02T19:17:56+01:00" level=info msg="GET /" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=5659 status=200 time="2023-11-02T19:17:56+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=38 status=200 time="2023-11-02T19:17:56+01:00" level=info msg="GET /api/tags" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=3 status=200 time="2023-11-02T19:17:59+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=test" proto=HTTP/1.1 remote="192.168.1.2:50884" reqlen=0 size=38 status=200 time="2023-11-02T19:18:00+01:00" level=info msg="POST /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:50884" reqlen=211 size=378 status=200 time="2023-11-02T19:18:02+01:00" level=info msg="GET /" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=5659 status=200 time="2023-11-02T19:18:02+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=430 status=200 time="2023-11-02T19:18:02+01:00" level=info msg="GET /api/tags" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=3 status=200 time="2023-11-02T19:18:03+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:50880" reqlen=0 size=23251 status=200 time="2023-11-02T19:19:17+01:00" level=info msg="PUT /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:60706" reqlen=427 size=24402 status=200 time="2023-11-02T19:19:24+01:00" level=info msg="GET /api/bookmarks?keyword=terra&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:60706" reqlen=0 size=479 status=200 time="2023-11-02T19:19:28+01:00" level=info msg="GET /api/accounts" proto=HTTP/1.1 remote="192.168.1.2:60706" reqlen=0 size=50 status=200 time="2023-11-02T19:19:31+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:60706" reqlen=0 size=23251 status=200 2023/11/02 19:20:15 Get "https://blogs.oracle.com/content/published/api/v1.1/assets/CONTCEBA0B3AED4240679C38D845E54FB5DF/Medium?cb=_cache_506c&amp;channelToken=f7814d202b7d468686f50574164024ec&amp;format=jpg": stream error: stream ID 3; INTERNAL_ERROR; received from peer time="2023-11-02T19:20:15+01:00" level=info msg="Serve shiori in :8080 /" time="2023-11-02T19:20:37+01:00" level=warning msg="PUT /api/ebook" proto=HTTP/1.1 remote="192.168.1.2:42482" reqlen=11 size=25 status=500 time="2023-11-02T19:20:39+01:00" level=info msg="GET /login?dst=http%3A%2F%2F192.168.1.3%3A9009%2F%3Fsearch%3Dterra%23home" proto=HTTP/1.1 remote="192.168.1.2:42482" reqlen=0 size=4299 status=200 time="2023-11-02T19:20:49+01:00" level=warning msg="GET /" proto=HTTP/1.1 remote="192.168.1.2:33532" reqlen=0 size=49 status=301 time="2023-11-02T19:20:49+01:00" level=info msg="GET /login?dst=%2F" proto=HTTP/1.1 remote="192.168.1.2:33532" reqlen=0 size=4299 status=200 time="2023-11-02T19:21:14+01:00" level=info msg="POST /api/login" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=83 size=151 status=200 time="2023-11-02T19:21:14+01:00" level=info msg="GET /" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=0 size=5659 status=200 time="2023-11-02T19:21:15+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=0 size=478 status=200 time="2023-11-02T19:21:15+01:00" level=info msg="GET /api/tags" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=0 size=85 status=200 time="2023-11-02T19:21:21+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=0 size=23382 status=200 time="2023-11-02T19:21:31+01:00" level=info msg="PUT /api/ebook" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=11 size=24403 status=200 time="2023-11-02T19:21:31+01:00" level=warning msg="GET /bookmark/1/ebook" proto=HTTP/1.1 remote="192.168.1.2:45974" reqlen=0 size=0 status=0 time="2023-11-02T19:22:00+01:00" level=info msg="GET /api/accounts" proto=HTTP/1.1 remote="192.168.1.2:43878" reqlen=0 size=50 status=200 time="2023-11-02T19:23:01+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=&exclude=&page=1" proto=HTTP/1.1 remote="192.168.1.2:38182" reqlen=0 size=478 status=200 time="2023-11-02T19:23:01+01:00" level=info msg="GET /api/tags" proto=HTTP/1.1 remote="192.168.1.2:38182" reqlen=0 size=85 status=200 time="2023-11-02T19:23:32+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:59754" reqlen=0 size=23382 status=200 time="2023-11-02T19:24:41+01:00" level=info msg="GET /api/bookmarks?keyword=&tags=test" proto=HTTP/1.1 remote="192.168.1.2:41388" reqlen=0 size=38 status=200 time="2023-11-02T19:25:55+01:00" level=info msg="GET /bookmark/1/content" proto=HTTP/1.1 remote="192.168.1.2:55438" reqlen=0 size=23382 status=200 time="2023-11-02T19:26:20+01:00" level=info msg="PUT /api/bookmarks" proto=HTTP/1.1 remote="192.168.1.2:49298" reqlen=423 size=24399 status=200 time="2023-11-02T19:28:16+01:00" level=info msg="PUT /api/ebook" proto=HTTP/1.1 remote="192.168.1.2:60124" reqlen=11 size=24400 status=200 time="2023-11-02T19:28:16+01:00" level=warning msg="GET /bookmark/1/ebook" proto=HTTP/1.1 remote="192.168.1.2:60124" reqlen=0 size=0 status=0 2023/11/02 19:35:21 Get "https://blogs.oracle.com/content/published/api/v1.1/assets/CONTCEBA0B3AED4240679C38D845E54FB5DF/Medium?cb=_cache_506c&amp;channelToken=f7814d202b7d468686f50574164024ec&amp;format=jpg": stream error: stream ID 3; INTERNAL_ERROR; received from peer time="2023-11-02T19:35:21+01:00" level=info msg="Serve shiori in :8080 /" ```
kerem commented 2026-02-25 23:34:04 +03:00
Author
Owner
Copy link

@fmartingr commented on GitHub (Nov 5, 2023):

Hey @pocelka, does your article have content in the reader view?

<!-- gh-comment-id:1793690009 --> @fmartingr commented on GitHub (Nov 5, 2023): Hey @pocelka, does your article have content in the reader view?
kerem commented 2026-02-25 23:34:04 +03:00
Author
Owner
Copy link

@pocelka commented on GitHub (Nov 5, 2023):

I’m not really sure what you mean by reader mode but I’ll say, yes it has. I included also link so you could test if that is article related or something else.

<!-- gh-comment-id:1793692544 --> @pocelka commented on GitHub (Nov 5, 2023): I’m not really sure what you mean by reader mode but I’ll say, yes it has. I included also link so you could test if that is article related or something else.
kerem commented 2026-02-25 23:34:04 +03:00
Author
Owner
Copy link

@fmartingr commented on GitHub (Nov 5, 2023):

Sorry, I missed that. Just tried the URL in 1.5.5 and latest master. 1.5.5 fails but latest master creates an ebook successfully though with missing images it seems, there are some network errors while trying to fetch things from oracle.com.

What is happening is that in 1.5.5 the server just crashes and don't continue, but in 1.6.0 we will be more fault tolerant.

<!-- gh-comment-id:1793694268 --> @fmartingr commented on GitHub (Nov 5, 2023): Sorry, I missed that. Just tried the URL in 1.5.5 and latest master. 1.5.5 fails but latest master creates an ebook successfully though with missing images it seems, there are some network errors while trying to fetch things from oracle.com. What is happening is that in 1.5.5 the server just crashes and don't continue, but in 1.6.0 we will be more fault tolerant.
kerem commented 2026-02-25 23:34:05 +03:00
Author
Owner
Copy link

@Monirzadeh commented on GitHub (Nov 5, 2023):

@fmartingr in your final epub do you have image too?

in long term i like to use image from local image in archive version but i should wait until #481 merge than try to use files inside local file instead of download them twice.

<!-- gh-comment-id:1793831193 --> @Monirzadeh commented on GitHub (Nov 5, 2023): @fmartingr in your final epub do you have image too? in long term i like to use image from local image in archive version but i should wait until #481 merge than try to use files inside local file instead of download them twice.
kerem commented 2026-02-25 23:34:05 +03:00
Author
Owner
Copy link

@fmartingr commented on GitHub (Nov 11, 2023):

@fmartingr in your final epub do you have image too?

in long term i like to use image from local image in reader mode but i should wait until #481 merge than try to use files inside local file instead of download them twice.

It didn't had images, they failed to download.

<!-- gh-comment-id:1806750339 --> @fmartingr commented on GitHub (Nov 11, 2023): > @fmartingr in your final epub do you have image too? > > in long term i like to use image from local image in reader mode but i should wait until #481 merge than try to use files inside local file instead of download them twice. It didn't had images, they failed to download.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/go_modules/all-ad9dc7761f
dependabot/github_actions/all-7ab03d418b
dependabot/go_modules/golang.org/x/crypto-0.45.0
dependabot/go_modules/github.com/docker/docker-28.3.3incompatible
feat/bookmarks-api-v1
dependabot/npm_and_yarn/webapp/npm_and_yarn-7372c7abf2
deps/update202509
feat/pdf-archiver
feat/apiv1/tags
release/v1.7
fix/thumbnail-cache
gh-pages
fix/openbsd-test-speed
release/v1.6.1
release/v1.6.0
fmartingr/windows-tests
afero-removal
ci/windows-macos
feat/cookie-auth
webroot-support-new-server
fix/secret-key-makefile
frontend-jwt-auth
fmartingr/issue663
fix/remove-tag-package-name
fmartingr/issue455
fix/delete-pr-tags
feat/cross-api-authentication
feat/api-v1-to-master
release/v1.5.5
feat/api-next
release/v1.5.5-rc.2
deps/go-1.20
fix/bookmark-update
draft/gorm
v1.8.0
v1.8.0-rc.1
v1.7.4
v1.7.3
v1.7.2
v1.7.2-rc.1
v1.7.1
v1.7.0
v1.7.0-rc.3
v1.7.0-rc.2
v1.7.0-rc.1
v1.6.3
v1.6.2
v1.6.1
v1.6.0
v1.6.0-rc.7
v1.6.0-rc.6
v1.6.0-rc.5
v1.6.0-rc.4
v1.6.0-rc.3
v1.6.0-rc.2
v1.6.0-rc.1
v1.5.5
v1.5.5-rc.2
v1.5.5-rc.1
v1.5.4
v1.5.3
v1.5.2
v1.5.1
v1.5.0
v1.0
v0.9
Labels
Clear labels   
component:backend

   
component:builds

   
component:builds

   
component:extension

   
component:frontend

   
component:readability

   
database

   
database:mysql

   
database:postgres

   
database:sqlite

   
feature:ebooks

   
github_actions

   
good first issue

   
hacktoberfest

   
note:duplicate?

   
note:fixed?

   
note:out-of-scope?

   
os:windows

   
priority:high

   
priority:low

   
pull-request

Mirrored from GitHub Pull Request

  
resolution:as-intended

   
resolution:cant-reproduce

   
resolution:duplicate

   
resolution:fixed

   
resolution:wontfix

   
tag:TBD

   
tag:big-task

   
tag:help-wanted

   
tag:huge-data

   
tag:meta

   
tag:more-info

   
tag:next

   
tag:no-stale

   
tag:requires-migrations

   
tag:research

   
tag:security 🛡️

   
tag:stale

   
tag:waiting-for-assignee

   
type:bug

   
type:documentation

   
type:enhancement

   
type:meta

   
type:ux

   
user:cli

   
user:web
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#372
No description provided.