mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #689] Archiv crashes shiori #346
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#346
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rmayergfx on GitHub (Aug 3, 2023).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/689
Data
Describe the bug / actual behavior
Doing a bookmark with archive with web extension:
URL to test:
https://kb.synology.com/de-de/DSM/tutorial/Which_Synology_NAS_supports_WDDA
Readable version is fine, klick on "View Archive" ist not opening local archive, tooks very long time and on the status line you see that the system is trying to connect to kb.synology.com and when the page finaly is loaded you the the Cookie Settings and a wired page with missing formatting.
@fmartingr commented on GitHub (Aug 5, 2023):
Thanks for the report, commenting on the two issues you experienced:
Regarding the archive result, since their page have the cookie banner pop up on top of everything, so when you archive the result would be the same, though our archive doesn't store/display styles.
I tried an archive using obelisk (the archiver that will replace the current one) and while the styles are ok, the content is not shown (and it took a minute and a half to archive):
In summary: there's no action for Shiori to take here.
If you want to help improve the archival of the page, please report it under obelisk so we can take that into consideration once we implement that here. Maybe we need to add some cookie bypass or something like that.