starred/shiori

Fork 0

mirror of https://github.com/go-shiori/shiori.git synced 2026-04-25 06:25:54 +03:00

[GH-ISSUE #55] Cache not working? #34

New issue

Closed

opened 2026-02-25 23:33:18 +03:00 by kerem · 9 comments

kerem commented

2026-02-25 23:33:18 +03:00

Owner

Originally created by @tomas on GitHub (Mar 6, 2018).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/55

Hi, just installed shiori on a server and trying it out. Looks great!

Unfortunately, I added a few bookmarks and none of them generated any cached versions. In what conditions does this happen? Is there some dependency that I have to install on my server?

Thanks

Originally created by @tomas on GitHub (Mar 6, 2018). Original GitHub issue: https://github.com/go-shiori/shiori/issues/55 Hi, just installed shiori on a server and trying it out. Looks great! Unfortunately, I added a few bookmarks and none of them generated any cached versions. In what conditions does this happen? Is there some dependency that I have to install on my server? Thanks

kerem closed this issue

2026-02-25 23:33:18 +03:00

kerem commented

2026-02-25 23:33:19 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Mar 7, 2018):

Hi @tomas, thanks for using this app and reporting this issue.

Is there some dependency that I have to install on my server ?

No, there are no dependency needed.

I added a few bookmarks and none of them generated any cached versions. In what conditions does this happen?

Normally, shiori should fetch the content by default. May I know how you add the bookmark ? Using command line, web interface or using shiori import ? If possible, could you give me the URL where shiori doesn't fetch any content ?

Thank you.

@RadhiFadlillah commented on GitHub (Mar 7, 2018): Hi @tomas, thanks for using this app and reporting this issue. > Is there some dependency that I have to install on my server ? No, there are no dependency needed. > I added a few bookmarks and none of them generated any cached versions. In what conditions does this happen? Normally, `shiori` should fetch the content by default. May I know how you add the bookmark ? Using command line, web interface or using `shiori import` ? If possible, could you give me the URL where `shiori` doesn't fetch any content ? Thank you.

kerem commented

2026-02-25 23:33:19 +03:00

Author

Owner

@tomas commented on GitHub (Mar 7, 2018):

Via the web interface, although I did try updating the link afterwards from the command line.

One of the links I tried was this small HTML page:

https://tinyapps.org/system.html

@tomas commented on GitHub (Mar 7, 2018): Via the web interface, although I did try updating the link afterwards from the command line. One of the links I tried was this small HTML page: https://tinyapps.org/system.html

kerem commented

2026-02-25 23:33:19 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Mar 8, 2018):

Hi @tomas, could you check it again ?

The caching process is done by go-readability, and I've push the fix at 9724ab.

@RadhiFadlillah commented on GitHub (Mar 8, 2018): Hi @tomas, could you check it again ? The caching process is done by [go-readability](https://github.com/RadhiFadlillah/go-readability), and I've push the fix at [9724ab](https://github.com/RadhiFadlillah/go-readability/commit/9724ab1cb1c74bebffc3db4344fa277852c67f77).

kerem commented

2026-02-25 23:33:19 +03:00

Author

Owner

@tomas commented on GitHub (Mar 8, 2018):

It works! However, links in the copied HTML are all wrong (they're somehow prepending the original link's hostname in them):

@tomas commented on GitHub (Mar 8, 2018): It works! However, links in the copied HTML are all wrong (they're somehow prepending the original link's hostname in them): ![image](https://user-images.githubusercontent.com/10574/37151774-b5e9eb62-22b5-11e8-91c5-2d6c3873bd37.png)

kerem commented

2026-02-25 23:33:19 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Mar 8, 2018):

Fixed in go-readability#558d9b4.

@RadhiFadlillah commented on GitHub (Mar 8, 2018): Fixed in [go-readability#558d9b4](https://github.com/RadhiFadlillah/go-readability/commit/558d9b48d988df9ee317530a104890b6a8c5b9a7).

kerem commented

2026-02-25 23:33:19 +03:00

Author

Owner

@tomas commented on GitHub (Mar 8, 2018):

Great, thanks.

Not related, but, would it be possible to have a bookmark added just by entering a URL and hitting the enter key? Having to use the mouse and click the "Done" button affects usability IMHO.

@tomas commented on GitHub (Mar 8, 2018): Great, thanks. Not related, but, would it be possible to have a bookmark added just by entering a URL and hitting the enter key? Having to use the mouse and click the "Done" button affects usability IMHO.

kerem commented

2026-02-25 23:33:19 +03:00

Author

Owner

@tomas commented on GitHub (Mar 8, 2018):

Oh and it looks like go-readability's content lookup doesn't work always. Here's another URL where I get an empty result: https://www.plop.at/en/bootmanager/index.html

@tomas commented on GitHub (Mar 8, 2018): Oh and it looks like go-readability's content lookup doesn't work always. Here's another URL where I get an empty result: https://www.plop.at/en/bootmanager/index.html

kerem commented

2026-02-25 23:33:19 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Mar 8, 2018):

Not related, but, would it be possible to have a bookmark added just by entering a URL and hitting the enter key? Having to use the mouse and click the "Done" button affects usability IMHO.

Yeah, it's in the future plan.

Oh and it looks like go-readability's content lookup doesn't work always. Here's another URL where I get an empty result.

Yeah, it's still in development and I haven't finished porting the entire methods from mozilla/readability. There are some parts of code that I find quite hard to port, especially since Go and JS have opposite character (static vs dynamic language), so PR and contributions are always welcome.

BTW, since go-readability is port of mozilla/readability (which powers reader mode in Firefox), that means if Firefox unable to render the readable format for a website, most likely go-readability can't do it as well.

@RadhiFadlillah commented on GitHub (Mar 8, 2018): > Not related, but, would it be possible to have a bookmark added just by entering a URL and hitting the enter key? Having to use the mouse and click the "Done" button affects usability IMHO. Yeah, it's in the future plan. > Oh and it looks like go-readability's content lookup doesn't work always. Here's another URL where I get an empty result. Yeah, it's still in development and I haven't finished porting the entire methods from [`mozilla/readability`](https://github.com/mozilla/readability). There are some parts of code that I find quite hard to port, especially since Go and JS have opposite character (static vs dynamic language), so PR and contributions are always welcome. BTW, since `go-readability` is port of `mozilla/readability` (which powers reader mode in Firefox), that means if Firefox unable to render the readable format for a website, most likely `go-readability` can't do it as well.

kerem commented

2026-02-25 23:33:19 +03:00

Author

Owner

@tomas commented on GitHub (Mar 8, 2018):

I see. golang isn't my weapon of choice, so unfortunately I cannot help you much with PRs in go-readability. Thanks again!

@tomas commented on GitHub (Mar 8, 2018): I see. golang isn't my weapon of choice, so unfortunately I cannot help you much with PRs in `go-readability`. Thanks again!

kerem referenced this issue

2026-02-25 23:34:31 +03:00

[PR #37] [CLOSED] Import tags from bookmark. #497