[GH-ISSUE #654] Title is never retrieved when adding bookmark #329

New issue

Closed

opened 2026-02-25 23:33:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:33:58 +03:00

Owner

Originally created by @fmartingr on GitHub (Jul 21, 2023).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/654

Originally assigned to: @fmartingr on GitHub.

Heads up: title is never retrieved
https://github.com/go-shiori/shiori/blob/v1.5.5-rc.1/internal/webserver/handler-api.go#L320-L322

// Make sure bookmark's title not empty
if book.Title == "" {
    book.Title = book.URL
}
// ^ because if this
// …
        bookmark, err := downloadBookmarkContent(book, h.DataDir, r, book.Title != "", book.Excerpt != "")
//                                                                   ^ it's always non-empty
// …
    book, err = downloadBookmarkContent(book, h.DataDir, r, book.Title != "", book.Excerpt != "")
//                                                          ^ it's always non-empty

Originally posted by @eitau in https://github.com/go-shiori/shiori/discussions/637#discussioncomment-6476870

Originally created by @fmartingr on GitHub (Jul 21, 2023). Original GitHub issue: https://github.com/go-shiori/shiori/issues/654 Originally assigned to: @fmartingr on GitHub. Heads up: title is never retrieved https://github.com/go-shiori/shiori/blob/v1.5.5-rc.1/internal/webserver/handler-api.go#L320-L322 ```go // Make sure bookmark's title not empty if book.Title == "" { book.Title = book.URL } // ^ because if this // … bookmark, err := downloadBookmarkContent(book, h.DataDir, r, book.Title != "", book.Excerpt != "") // ^ it's always non-empty // … book, err = downloadBookmarkContent(book, h.DataDir, r, book.Title != "", book.Excerpt != "") // ^ it's always non-empty ``` _Originally posted by @eitau in https://github.com/go-shiori/shiori/discussions/637#discussioncomment-6476870_