[GH-ISSUE #549] Clicking on tag shows no bookmarks in search #305

New issue

Closed

opened 2026-02-25 23:33:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:33:55 +03:00

Owner

Originally created by @ryanwr on GitHub (Jan 5, 2023).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/549

Data

Shiori version: 1.5.3
Database Engine: SQLite
Operating system: Docker
CLI/Web interface/Web Extension: Web interface

Describe the bug / actual behavior

When clicking on a tag on a bookmark that is in a page > 1, it results in the search returning no results.

Expected behavior

Bookmarks are returned in results.

To Reproduce

Steps to reproduce the behavior:

Add more than 30 bookmarks (or however many bookmarks required to create more than 1 page).
Add a tag to the last bookmark on page 2.
Click the tag on the bookmark on page 2
It will add the 'tag:my-tag' filter to search and show no results

Notes

This issue is caused because the page query parameter is not stripped when clicking on a tag on a bookmark.

If you are on page 2 the url is as follows:

/?page=2

Click on tag e.g. 'webdev'.

/?page=2&search=tag%3Awebdev

However there is only 1 bookmark and hence page 2 is empty.

Probably just needs to set this.page = 1; here:
github.com/go-shiori/shiori@a950bfec4c/internal/view/js/page/home.js (L295-L297)

I can create a PR if it is an acceptable fix.

Thanks,
Ryan

Originally created by @ryanwr on GitHub (Jan 5, 2023). Original GitHub issue: https://github.com/go-shiori/shiori/issues/549 ## Data - **Shiori version**: 1.5.3 - **Database Engine**: SQLite - **Operating system**: Docker - **CLI/Web interface/Web Extension**: Web interface ## Describe the bug / actual behavior When clicking on a tag on a bookmark that is in a page > 1, it results in the search returning no results. ## Expected behavior Bookmarks are returned in results. ## To Reproduce Steps to reproduce the behavior: 1. Add more than 30 bookmarks (or however many bookmarks required to create more than 1 page). 2. Add a tag to the last bookmark on page 2. 3. Click the tag on the bookmark on page 2 4. It will add the 'tag:my-tag' filter to search and show no results ## Notes This issue is caused because the page query parameter is not stripped when clicking on a tag on a bookmark. If you are on page 2 the url is as follows: `/?page=2` Click on tag e.g. 'webdev'. `/?page=2&search=tag%3Awebdev` However there is only 1 bookmark and hence page 2 is empty. Probably just needs to set `this.page = 1;` here: https://github.com/go-shiori/shiori/blob/a950bfec4c75eadbe5c1a03302ba9875a8236d45/internal/view/js/page/home.js#L295-L297 I can create a PR if it is an acceptable fix. Thanks, Ryan