[GH-ISSUE #517] Cannot add bookmarks using shiori git #297

Closed
opened 2026-02-25 23:33:53 +03:00 by kerem · 4 comments
Owner

Originally created by @cycomanic on GitHub (Oct 15, 2022).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/517

Originally assigned to: @fmartingr on GitHub.

If I try to add bookmarks a recent shiori from git and the bookmark does not already exist I get an error:

failed to get bookmark, URL: sql: no rows in result set 

If I add the bookmark through another means and then add it again (possibly with added tags) all works ok

Originally created by @cycomanic on GitHub (Oct 15, 2022). Original GitHub issue: https://github.com/go-shiori/shiori/issues/517 Originally assigned to: @fmartingr on GitHub. If I try to add bookmarks a recent shiori from git and the bookmark does not already exist I get an error: ``` failed to get bookmark, URL: sql: no rows in result set ``` If I add the bookmark through another means and then add it again (possibly with added tags) all works ok
Author
Owner

@fmartingr commented on GitHub (Oct 15, 2022):

We've made some changes to the latest development build, let me take a look at what's missing. Also, moving this issue to Shori's repository.

<!-- gh-comment-id:1279703643 --> @fmartingr commented on GitHub (Oct 15, 2022): We've made some changes to the latest development build, let me take a look at what's missing. Also, moving this issue to Shori's repository.
Author
Owner

@fmartingr commented on GitHub (Oct 15, 2022):

Hey @cycomanic, can you try out the changes in #518? I believe I reproduced it correctly and fixed another related error.

<!-- gh-comment-id:1279722254 --> @fmartingr commented on GitHub (Oct 15, 2022): Hey @cycomanic, can you try out the changes in #518? I believe I reproduced it correctly and fixed another related error.
Author
Owner

@cycomanic commented on GitHub (Oct 15, 2022):

@fmartingr I can confirm that #518 fixes the issue

<!-- gh-comment-id:1279725306 --> @cycomanic commented on GitHub (Oct 15, 2022): @fmartingr I can confirm that #518 fixes the issue
Author
Owner

@fmartingr commented on GitHub (Oct 15, 2022):

@fmartingr I can confirm that #518 fixes the issue

Awesome, thanks for the catch and the help!

<!-- gh-comment-id:1279733561 --> @fmartingr commented on GitHub (Oct 15, 2022): > @fmartingr I can confirm that #518 fixes the issue Awesome, thanks for the catch and the help!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#297
No description provided.